Further work on the mqtt module #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made a number of changes to allow more than one mqtt instance. This is meant to provide support for multiple hosts and ports pairs. I noticed that using the same host:port would cause the second request to be disconnected. So I reused the first host:port instance (I really only wanted the socket). So I reused the instance and issued a new subscription. This has man side effects that need to be worked out. There are a number of other fix "me"s and todos (listed in the source). Reconnect handleing among the top issues. See Usage and Example in the source file for changes to instanctiation.
hollie
added a commit
that referenced
this pull request
Jul 26, 2015
Further work on the mqtt module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a number of changes to allow more than one mqtt instance. This is
meant to provide support for multiple hosts and ports pairs. I noticed that
using the same host:port would cause the second request to be disconnected. So I
reused the first host:port instance (I really only wanted the socket). So I
reused the instance and issued a new subscription. This has man side effects
that need to be worked out.
There are a number of other fix "me"s and todos (listed in the source).
Reconnect handleing among the top issues.
See Usage and Example in the source file for changes to instanctiation.