Perltidy run #557
Merged
Perltidy run #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable Pod::Tidy as it doesn't do much, and would require an additional annoying install.
This is all a guess at this point
Batch files are freaking annoying
More windows annoyances
No "need" to tidy these. This saves us time and headaches.
The problems are predominantly in the code examples and likely exist because these files are not normally run. As a side note, this really demonstrates how awful our failure to remove non functioning code has become. A few bugs also existed in some lib items. I did my best to fix them in what I believe to be the proper manner. However, not using these libraries I can't be sure I did it right.
Enable fast deletion of backup and error logs.
Perltidy will split long lines at equal signs. This can cause issues with the MH User_Code parser that attempts to location 'new' statements. This attempts to fix the problem by merging multi line statements that fit this format into a single line before parsing.
…perltidy a second time
|
Been running for a few days with my numerous insteon devices and all is well. I was going to replace a switch soon which will test more of the mh insteon features. |
|
John, thanks for testing and reporting! |
# Conflicts: # lib/read_table_A.pl
# Conflicts: # lib/json_server.pl
hollie
added a commit
that referenced
this pull request
Dec 5, 2015
Perltidy run: cleanup of the codebase before releasing new stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second pull request for the perltidy cleanup. This time it contains all changes created by the perltidy_all script, plus a few manual fixes for files that were not handled correctly by perltidy.
Please check if MisterHouse is still running fine on your system after this pull request.