Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only include the PLCBUS module if we actually need it. #558

Merged
merged 1 commit into from
Nov 15, 2015
Merged

Only include the PLCBUS module if we actually need it. #558

merged 1 commit into from
Nov 15, 2015

Conversation

hollie
Copy link
Owner

@hollie hollie commented Nov 15, 2015

Otherwise we require users to install supporting modules for PLCBUS.

@hollie
Only include the PLCBUS module if we actually need it.
324000c 
Otherwise we require users to install supporting modules for PLCBUS.
@hollie hollie mentioned this pull request Nov 15, 2015
Merged
hollie added a commit that referenced this pull request Nov 15, 2015
@hollie
Merge pull request #558 from hollie/fix_plcbus_module_requirement
4a403f5 
Only include the PLCBUS module if we actually need it.
@hollie hollie merged commit 4a403f5 into master Nov 15, 2015
@hollie hollie deleted the fix_plcbus_module_requirement branch November 15, 2015 17:24
@hollie hollie restored the fix_plcbus_module_requirement branch November 22, 2015 13:38
@hollie
Copy link
Owner Author

hollie commented Nov 22, 2015

Hey @tobser
is it OK if I change the line to 'require PLCBUS;'? This way the module is included at runtime when required.

I've already updated the fix_plcbus_module_requirement branch. Can you please test out and let me know if this is OK for you?

Best regards,
Lieven.

@hollie
Copy link
Owner Author

hollie commented Nov 22, 2015

See the fix here: #562

@tobser
Copy link
Contributor

tobser commented Nov 26, 2015

Hey Lieven,
your patch works fine. Thanks.

regads
Tobi

Am 22.11.2015 um 14:46 schrieb Lieven Hollevoet:

Hey @tobser https://github.com/tobser
is it OK if I change the line to 'require PLCBUS;'? This way the
module is included at runtime when required.

I've already updated the fix_plcbus_module_requirement branch. Can you
please test out and let me know if this is OK for you?

Best regards,
Lieven.

—
Reply to this email directly or view it on GitHub
#558 (comment).

@hollie
Copy link
Owner Author

hollie commented Nov 26, 2015

Hello Tobi,

thanks for testing. Merged!

Best regards,
Lieven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hollie @tobser