Various fixes for AD2.pm and New Harmon Kardon receiver module. #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 10, 2015 22:43
1. In the AD2_Output sub set added a set to fix output device control 2. For some reason $Configuration was not working for the sub DefineCmdMsg, I changed it to $::config_parms and its working now 3. In the sub output_cmd I changed "start" from #7 to #8 because #8 is the command to open a relay so it makes sense that it would be 'start'. 4. In the partition sub set, it seems to always use the old "cmd" sub to send message and I was getting a invalid password. I changed it to always use the new set sub. 5. commented "$p_state = lc($p_state);" in the new cmd set sub because the commands didn't match the CmdMsg hash when they were changed to lower case. We could also change commands in the CmdMsg hash to lower case which might make more sense so the user code case won't matter. 6. The partition status was not being updated correctly due to the index function returning a -1, changed the if statement to >= 1 and now the parent object reflects correct "armed" state.
- $main::Serial_Ports{$instance}{'socket'}->write("$cmd");
+$main::Serial_Ports{$instance}{object}->write("$cmd");
hplato
added a commit
that referenced
this pull request
Jan 3, 2016
Various fixes for AD2.pm and New Harmon Kardon receiver module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.