Insteon: Self Adjusting Hop Count #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hop_history function which adds a hop count to an array of a maximum length of 10. Then takes the highest hop value from the history and sets it as the default_hop_count. In addition, anytime a message needs to be resent, the default hop count is immediately bumped up by 1. Previously if default_hops was at 2 it required 2 failures before bumping the hop count to 3. The default hop count is bumped up by adding a hop count of that value to the hop history. This results in the value of default_hop as being the highest hop count needed for the last 10 sent or received messages.
Oops, hop_tracking is not enabled for PLM
No need to have a seperate function for this. The array system seems to work very well.
krkeegan
added a commit
that referenced
this pull request
Feb 15, 2013
Insteon: Self Adjusting Hop Count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks the number of hops required for the last 10 messages and uses the highest hop count of those 10 as the default_hop_count.
If a message requires resending, the hop count is immediately increased by 1, that increased hop count is tossed into the array and will last for 10 subsequent messages.
I have found this and all of my other corruption corrections to result in a very reliable system.