Add multiple path support #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
social-anthrax
commented
Mar 6, 2023
| @@ -518,7 +518,7 @@ fn multiple_paths() -> TestResult { | |||
| assert_eq!(final_build_size, size_after_dry_run_clean); | |||
|
|
|||
| // Run a proper cargo-sweep ("clean") in the target directories | |||
| let mut args = vec!["-r", "--time", "0"]; | |||
| let mut args = vec!["--time", "0"]; | |||
There was a problem hiding this comment.
We only want to test the functionality for multiple paths, setting both the multiple paths and recursive could cause an error in either one so I just wanted to minimise the test case.
jyn514
requested changes
Mar 6, 2023
jyn514
approved these changes
Mar 6, 2023
|
Thanks! |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95.
Adds support to process multiple paths.
Using the --stamps flag together with multiple paths will now cause an error.
Breaking Changes
cargo sweep --toolchains 1 2 3no longer causes the expected error as 2 and 3 are read as paths.