Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up how the recessive flag works #17

Merged
merged 7 commits into from
Jan 6, 2019
Merged

Conversation

Eh2406
Copy link
Collaborator

@Eh2406 Eh2406 commented Jan 4, 2019

This ended up being a big PR, but each commit is small and focused. The goal of this was to get cargo sweep -i -r to work on my documents folder.

Some things that needed to be fixed for my projects:

  • Some cargo project specify a different name for the target dir.
  • Some even use a shared folder several levels up from where the Cargo.toml is.
  • Some, maybe just Cargo itself, have full projects in the target dir for testing.
  • There are a lot of files in .git folder that do not need to be searched.

with this cargo sweep -i -r on my documents is fast and reliable enough to add to my rustup update script.

@holmgr
Copy link
Owner

holmgr commented Jan 6, 2019

Looks really good to me! Great work 👍

@holmgr holmgr merged commit 36362c5 into holmgr:master Jan 6, 2019
@Eh2406
Copy link
Collaborator Author

Eh2406 commented Jan 6, 2019

Thanks for letting me work on your project!

@holmgr
Copy link
Owner

holmgr commented Jan 6, 2019

No problem, I do very much appreciate anyone who wants to contribute to this project! :)

@Eh2406 Eh2406 deleted the clean_r branch January 10, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants