Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it is called cargo-sweep not hello #18

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Conversation

Eh2406
Copy link
Collaborator

@Eh2406 Eh2406 commented Jan 6, 2019

I don't know if this is sufficient to make the next release easily installable, but I think it is a step in the correct direction. cc #4 (comment), I think when this is working it will be possible to install without building from scratch with something like this. I can confirm that 0.3.0 does not support it, but I do not know if this is enough to get it working.

@epage any other advice for getting this set up or for testing that it is working correctly?

@holmgr
Copy link
Owner

holmgr commented Jan 7, 2019

Ah, I left placeholders, :P Good job @Eh2406!
Lets see if it works now then :)

@holmgr holmgr merged commit 4770ded into holmgr:master Jan 7, 2019
@Eh2406 Eh2406 deleted the install branch January 10, 2019 21:59
@Eh2406
Copy link
Collaborator Author

Eh2406 commented Jan 23, 2019

I would love to see a 0.3.1 when you have a chance so we can test this out.

@holmgr
Copy link
Owner

holmgr commented Jan 23, 2019

Yes, I will do a new release today so we can see, we have a few new features etc, thanks to you! :)

@Eh2406
Copy link
Collaborator Author

Eh2406 commented Jan 24, 2019

@jtgeibel did some testing at rust-lang/crates.io#1602 and found that "I didn't try curl -LSfs https://japaric.github.io/trust/install.sh | sh -s -- --git holmgr/cargo-sweep because it looks like it expects precompiled binaries to be attached to the release on github."

I don't know how we have trust set up wrong, but it is not making the release correctly.

@holmgr
Copy link
Owner

holmgr commented Jan 25, 2019

Hmm, we will have to look into that. Not familiar with trust before, just tried to follow the instruction available but I must have made some mistakes. Will try to look into it on Sunday if I have time.

@Eh2406
Copy link
Collaborator Author

Eh2406 commented Jan 25, 2019

Ya, I have never used trust ether. I wish I could be more help.

@Eh2406
Copy link
Collaborator Author

Eh2406 commented Jan 25, 2019

The install script is definitely not working. https://travis-ci.org/Eh2406/cargo/jobs/484542914#L621-L631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants