Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show total cleaned/to clean amount #45

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

birkenfeld
Copy link
Contributor

fixes #43

@jyn514 jyn514 added the S-waiting-on-review Status: Awaiting review from a maintainer label Aug 12, 2022
@jyn514
Copy link
Collaborator

jyn514 commented Dec 1, 2022

This looks good! Sorry for the long delay. If you rebase this and add tests we can get it merged :) see tests/integration.rs for existing examples.

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer labels Dec 1, 2022
@birkenfeld birkenfeld force-pushed the issue43 branch 2 times, most recently from 4d0a722 to 85157e7 Compare December 3, 2022 07:26
@birkenfeld
Copy link
Contributor Author

Updated! Failures in clippy are unrelated and due to newest nightly introducing new warnings.

src/main.rs Outdated Show resolved Hide resolved
@marcospb19
Copy link
Collaborator

Thanks for your contribution ❤️.

I hope you don't mind, this one have been stale for 9 months, so I rebased it for you in order to solve the conflicts, and did the small fix Jyn asked.

Merging!

@marcospb19 marcospb19 merged commit 09588ab into holmgr:master Sep 18, 2023
9 checks passed
@marcospb19 marcospb19 mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cumulative size for dry run
3 participants