Switch from failure to anyhow
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is due to rust-lang/cargo#9788 I believe |
jyn514
reviewed
Aug 12, 2022
| @@ -218,7 +218,7 @@ fn main() { | |||
| debug!("Writing timestamp file in: {:?}", path); | |||
| match Timestamp::new().store(path.as_path()) { | |||
| Ok(_) => {} | |||
| Err(e) => error!("Failed to write timestamp file: {}", e), | |||
| Err(e) => error!("Failed to write timestamp file: {:?}", e), | |||
There was a problem hiding this comment.
anyhow has, to my knowledge, 2 different error output options. One just prints a simple one-line error message, which is usually just the error context. The other is more detailed and prints the entire error chain. Here is an example of the second option, taken from anyhow's docs:
Error: Failed to read instrs from ./path/to/instrs.json
Caused by:
No such file or directory (os error 2)
I opted for the second option as it is more detailed and more helpful if one runs into an error.
There was a problem hiding this comment.
ah perfect - for some reason I thought it was {:#} but the docs say it's {:?} like you have here: https://docs.rs/anyhow/latest/anyhow/struct.Error.html#display-representations
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the error type of this CLI from
failuretoanyhowsincefailureis deprecated now.