Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assure link between evm signer and signing offer #68

Open
8e8b2c opened this issue Aug 2, 2024 · 0 comments
Open

Assure link between evm signer and signing offer #68

8e8b2c opened this issue Aug 2, 2024 · 0 comments

Comments

@8e8b2c
Copy link
Collaborator

8e8b2c commented Aug 2, 2024

Relates to #31

Option 1

Add a wallet_attestation_ah field to EvmSigningOffer which is validated to have the same author. Then links against an evm address can be validated against the attestation. The evm-bytes-signer micro-service would ensure the attestation exists on launch.

Pros

  • Simple implementation

Cons

  • (minor) Link validation requires chaining must_gets
  • A compromised agent can freely reuse a wallet attestation; similarly a phished evm signature could be reused indefinitely

Option 2

Nest EvmSigningOffer inside of a SignedEvmSigningOffer. The evm-bytes-signer micro-service then signs this offer as part of creation.

Pros

  • Knowledge that offers have been individually approved by the wallet owner

Cons

  • Slightly more work to implement
  • Confusing struct name: SignedEvmSigningOffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant