feat!: verifiably locate signing offers against signer address #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nphias
added a commit
that referenced
this pull request
Aug 6, 2024
feat!: verifiably locate signing offers against signer address (#74)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #68
EvmSigningOffers are now wrapped in aSignedEvmSigningOffersuch that users can locate such offers with confidence that they originate from the evm signer that the user seeks.This is achieved by including the evm signer's address and signature over the offer, and verifying the signature at validation time. The offer is then linked against the evm signer's address (which is enforced to match what has already been validated).