8 missing sweetest for external id #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to branch
fix: auto select latest external ID; catch bad jq programs; format ge…
Closed
8e8b2c
requested changes
Aug 1, 2024
|
|
||
| //this test anticipates future code changes that chnage tht behaviour | ||
| #[tokio::test(flavor = "multi_thread")] | ||
| async fn same_external_id_cannot_be_registered_twice_from_another_user() { |
There was a problem hiding this comment.
Please remove this test, and instead open an issue to track the feature request. It's really confusing to have a test that asserts the opposite of what it say it asserts.
| // Alice gets the external_id Attestation | ||
| setup.consistency().await; | ||
|
|
||
| let maybe_record2: Vec<Record> = setup |
There was a problem hiding this comment.
Confusing name given its a vec
| #[tokio::test(flavor = "multi_thread")] | ||
| async fn only_authority_can_confirm_request() { | ||
| let setup = TestSetup::authority_and_alice().await; | ||
| //setup.conductors.exchange_peer_info().await; |
|
|
||
|
|
||
|
|
||
| //this test anticipates future code changes that chnage tht behaviour |
There was a problem hiding this comment.
Spelling! I know I've asked you delete this test anyway, but this seems like a good opportunity to remind you about:
https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.