Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign zome calls via electron #205

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Conversation

mattyg
Copy link
Member

@mattyg mattyg commented Sep 16, 2023

Support for signing zome calls in electron, as expected by https://github.com/mattyg/holochain-kangaroo-electron ( which itself exposes http://github.com/mattyg/holochain-lair-signer )

If window.__HC_LAUNCHER_ENV__.FRAMEWORK is set to 'electron', then the client will try to call window.electronAPI.signZomeCall(). If FRAMEWORK is set to 'tauri' or undefined, then it will call tauri's invoke() function.

This also changes how the client checks if it is in a launcher environment -- instead of checking window.__HC_LAUNCHER_ENV__ once when initially loaded, it will check every time a launcher overridable function is called.

@mattyg mattyg changed the title Feat/electron launcher Sign zome calls via electron Sep 16, 2023
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
please fix the typo and we could shorten the zome call signing function

CHANGELOG.md Outdated Show resolved Hide resolved
src/api/app/websocket.ts Outdated Show resolved Hide resolved
mattyg and others added 2 commits September 18, 2023 19:35
Co-authored-by: Jost Schulte <jost.schulte@protonmail.com>
Co-authored-by: Jost Schulte <jost.schulte@protonmail.com>
@jost-s jost-s merged commit ca0cf8a into holochain:main Sep 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants