Change .connect() api #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattyg
changed the title
…tions arg for specifying url & timeout
mattyg
changed the title
|
Let me know what you think @jost-s -- we might also want to get some feedback first. |
|
Sorry @mattyg for not getting back to you. I don't know what happened, I saw the PR a while ago. It looks fine to me, I'm happy with your proposal. I'll check with Holo and Components but don't think they'll object. |
jost-s
approved these changes
Feb 20, 2024
|
heads up @jost-s I don't actually have permissions to merge this -- if you were waiting on me |
|
No, I've just been ill. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels very weird that we have to pass a url of
new URL('ws://UNUSED')to setup a websocket connection within a launcher environment.This PR:
.connect()functions take an optionaloptionsobject, which contains optional properties:urlanddefaultTimeoutconnectfunction throw an error if the url is not defined by parameter, nor by launcher envAppAgentWebsocket.connectfunction, so the required parameter goes firstThis would be a breaking change.