Backport: New install app payload #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update InstallAppRequest type to new format * add new YamlProperties type and test that installs app with roles_settings set * use js-yaml in test * remove unnecessary fields, remove js-yaml from dependencies, convert pubkey to Uint8Array to have deepEqual work properly * more redundant membrane_proof fields, revert hdk bump * removed unused roles_settings fields
matthme
commented
Nov 28, 2024
| @@ -1548,7 +1548,7 @@ test( | |||
| }) | |||
| ); | |||
|
|
|||
| test.only( | |||
| test( | |||
There was a problem hiding this comment.
I'm assuming that this was accidental...
|
I've fixed the tests now that DPKI is no longer present. |
|
Looks like tests passed - is it approvable now? =D |
jost-s
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.