New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when setting up tests should cause non-zero exit code #93

Closed

harlantwood wants to merge 1 commit into holochain:develop from harlantwood:patch-2

harlantwood commented Nov 23, 2021

Without this, if we crash while setting up tests, the test command will return a zero exit code, and builds will report as green.


          Failing tests should cause non-zero exit code

668e9cc

Author

harlantwood commented Nov 23, 2021

Inspired by a fix to where, which was broken here (but CI green):
https://github.com/lightningrodlabs/where/actions/runs/1387171777

Then red once we merged a similar fix (https://github.com/lightningrodlabs/where/pull/22/files):
https://github.com/lightningrodlabs/where/actions/runs/1387248783

Author

harlantwood commented Nov 27, 2021

jost-s reviewed

View reviewed changes

Contributor

jost-s left a comment

In the new repo I got rid of tap-diff and all the other TAP reporters. The issue is resolved then, tape returns the correct exit code.

Contributor

jost-s commented Jan 12, 2022

Closing this as this repo will be archived.

jost-s closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet