This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
0.0.6 merge: Compare hashes before installing DNA #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maackle
changed the title
zippy
approved these changes
Mar 7, 2019
maackle
changed the title
lucksus
approved these changes
Mar 7, 2019
lucksus
previously requested changes
Mar 7, 2019
Connoropolous
approved these changes
Mar 7, 2019
Connoropolous
changed the title
Connoropolous
dismissed
lucksus’s stale review
changes were addressed, and Nico is unavailable at the moment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional
expected_hashparameter to admin/dna/install_from_file, which will fail installation if the hash of the DNA produced from the file does not match expected hash. Ifexpected_hashis not passed, the DNA will be installed with no hash check.TODO: do the same for UI, although we need to decide how UIs should be reliably hashed first