Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Intergration Crud Status Test Moved To App_spec #1096

Merged
merged 64 commits into from
Mar 8, 2019
Merged

Intergration Crud Status Test Moved To App_spec #1096

merged 64 commits into from
Mar 8, 2019

Conversation

StaticallyTypedAnxiety
Copy link
Contributor

@StaticallyTypedAnxiety StaticallyTypedAnxiety commented Mar 7, 2019 •
edited
Loading

  • I have added a summary of my changes to the changelog
  • Moved handle_remove_ok into App_Spec
  • Moved handle_update_ok into App_Spec
  • Moved handle_remove_update_ok into App_Spec

@StaticallyTypedAnxiety StaticallyTypedAnxiety changed the title Delete Entry App_Spec_Crud_Status [WIP]Delete Entry App_Spec_Crud_Status Mar 7, 2019
@StaticallyTypedAnxiety StaticallyTypedAnxiety changed the title [WIP]Delete Entry App_Spec_Crud_Status [WIP]Intergration Status Crud Test Moved To App_spec Mar 7, 2019
@StaticallyTypedAnxiety StaticallyTypedAnxiety changed the title [WIP]Intergration Status Crud Test Moved To App_spec Intergration Status Crud Test Moved To App_spec Mar 8, 2019
@StaticallyTypedAnxiety StaticallyTypedAnxiety changed the title Intergration Status Crud Test Moved To App_spec Intergration Crud Status Test Moved To App_spec Mar 8, 2019
lucksus
lucksus approved these changes Mar 8, 2019
View reviewed changes
Copy link
Collaborator

@lucksus lucksus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few remarks concerning code comments...

app_spec/test/test.js Outdated Show resolved Hide resolved
app_spec/test/test.js Outdated Show resolved Hide resolved
app_spec/test/test.js Outdated Show resolved Hide resolved
app_spec/test/test.js Outdated




Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newlines

Nicolas Luck and others added 6 commits March 8, 2019 14:11
Merge branch 'develop' into app_spec_crud_tests
e5bb98a
Merge branch 'develop' into app_spec_crud_tests
b24a7a5
@StaticallyTypedAnxiety
Update app_spec/test/test.js
fec7989 
Co-Authored-By: AshantiMutinta <AshantiMutinta@gmail.com>
@StaticallyTypedAnxiety
Update app_spec/test/test.js
b12ba35 
Co-Authored-By: AshantiMutinta <AshantiMutinta@gmail.com>
@StaticallyTypedAnxiety
Update test.js
422b27e
@StaticallyTypedAnxiety
Update app_spec/test/test.js
af786fe 
Co-Authored-By: AshantiMutinta <AshantiMutinta@gmail.com>
@StaticallyTypedAnxiety StaticallyTypedAnxiety merged commit 62bc4de into develop Mar 8, 2019
@zippy zippy deleted the app_spec_crud_tests branch July 5, 2019 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucksus lucksus lucksus approved these changes

@zippy zippy zippy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StaticallyTypedAnxiety @zippy @lucksus