Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Fix sim2h dependence on agent signing for hosted hApps use-case #2203

Merged
merged 24 commits into from
Sep 17, 2020

Conversation

zippy
Copy link
Member

@zippy zippy commented Jul 24, 2020

PR summary

In the use-case of a remote signing service that is not always guaranteed to be available (as in the hosted happs usecase of holo), assumptions in sim2h for message integrity that rely on agents signing all messages, breaks down.

This PR fixes this issue by only requiring that the Join message be signed by the agent. This works along with wss because the connection (which is long lasting) is then secured by the tls layer.

  • convert panic to error on sim2h_worker signing fail
  • sign only Join messages
  • add explicit SigningServiceError for dna's to handle
  • add back wss to ensure connection integrity

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@zippy zippy force-pushed the hosted-happ-fixes branch from 1554bb7 to e75bca1 Compare July 29, 2020 18:48
@zippy zippy marked this pull request as ready for review September 17, 2020 15:57
@zippy zippy merged commit 3bca5c4 into develop Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants