Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

More hold mismatch fixes #2208

Merged
merged 8 commits into from
Sep 3, 2020
Merged

More hold mismatch fixes #2208

merged 8 commits into from
Sep 3, 2020

Conversation

zippy
Copy link
Member

@zippy zippy commented Aug 25, 2020

PR summary

  • Fixed memory leak in various timeout conditions of direct messages
  • Fixed holding-list/CAS mismatch potential in various error conditions when sim2h requests aspect holding
  • Fixed bug in holding remove link before add-link validation complete

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@zippy zippy requested review from lucksus and zo-el August 26, 2020 19:53
@zippy zippy marked this pull request as ready for review August 26, 2020 19:53
@zippy zippy merged commit 6820fc8 into develop Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant