Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Replace s.consistency with sleep fn in scaffold #2209

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Sep 23, 2020

PR summary

This replaces the (now broken) await s.consistency() with a one-second sleep function in the scaffolded test script. Discovered when I was going through the blessing process for .52.

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

This replaces the (now broken) `await s.consistency()` with a one-second sleep function in the scaffolded test script.
@pdaoust pdaoust added bug Something isn't working good first issue Good for newcomers regression WIP work in progress labels Sep 23, 2020
@pdaoust pdaoust removed WIP work in progress good first issue Good for newcomers labels Sep 23, 2020
@pdaoust pdaoust requested a review from maackle September 23, 2020 22:21
@pdaoust pdaoust changed the title [WIP] Replace s.consistency with sleep fn in scaffold Replace s.consistency with sleep fn in scaffold Sep 24, 2020
@pdaoust pdaoust requested a review from zippy September 24, 2020 16:38
@pdaoust
Copy link
Collaborator Author

pdaoust commented Sep 24, 2020

Added quick note in the scaffold template to say that you'll probably need to adjust the timeout value.

@zippy zippy merged commit e379468 into develop Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants