This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
noodling with libzmq linking #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain-rust into 2019-01-07-static-libzmq
…19-01-07-static-libzmq
…nto 2019-01-07-static-libzmq
…hain-rust into 2019-01-07-static-libzmq
thedavidmeister
changed the title
thedavidmeister
requested review from
ddd-mtl,
zippy,
pjkundert,
StaticallyTypedAnxiety,
Connoropolous and
neonphog
thedavidmeister
changed the title
neonphog
reviewed
Jan 10, 2019
| #[cfg(windows)] | ||
| // hack to get the libzmq dll on the PATH | ||
| // copies it next to cargo | ||
| // kind of messy, is less than 1MB |
There was a problem hiding this comment.
👍 I like this as an interim solution until we get static linking working... since this is where cargo install will put the binaries in any case.
neonphog
approved these changes
Jan 10, 2019
zippy
approved these changes
Jan 10, 2019
|
this is a big improvement for usability, externally. Yay! Will seek to bring any related documentation in line with this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
zmq-sysso thatLIBZMQ_PREFIXis never neededubuntubox on circle to demonstrate installation (develop branch only)LIBZMQ_PREFIXfrom windows builds on travisCARGOdir so it can be found on the path by the compiler build scriptsPATHlogic for libzmq on travis/windows--releaseto cargo tests on travis to alleviate pressure on the cache (was timing out uploads)test cmdto circle because it breaks on travis (doesn't run standard installation)