-
Notifications
You must be signed in to change notification settings - Fork 267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zippy I notice you've been inclined to start adding environment variables recently...
can you say what motivates that? I think we should start out with a really solid practice documentation approach for those, in a centralized place as well as in context for its use, since I felt that was a very obscure and hard to work with aspect of holochain-proto.
This is a good point about documentation. Motivation is that I find them a very clean easy and expected way to get data into commands that lends itself to temporary settings via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no tests for this worries me
ok @Connoropolous , I got all the tests refactored and working, locally at least, we'll see what happens with CI. But I will disable them again before merge because they still do take way too long. |
@zippy is this for after the release? |
Yep not part of 0.0.3. I just pushed turning off that run test, because it takes too long for travis. You can turn it on and test locally if you like. Otherwise please re-review so we can merge using http in hc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, well I'm still seeing issues in this area of the code, but they aren't related to this PR per say.
If we could create some followups because there's clearly something off if we are writing code that we can't test, which is true of the scaffold stuff. The essential challenge is that to consistently test it we need the scaffold values to be dynamic, but during releases, we want the values to be fixed. That should prbly be the basis of the followup.
this just adds an env var so people can use the http interface with
hc run