Space Module Stubs #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com>
Closed
Closed
ThetaSinner
reviewed
Nov 28, 2024
ThetaSinner
reviewed
Nov 28, 2024
ThetaSinner
reviewed
Nov 28, 2024
mattyg
previously approved these changes
Nov 28, 2024
jost-s
previously approved these changes
Nov 28, 2024
Co-authored-by: Jost Schulte <28270981+jost-s@users.noreply.github.com>
Merged
neonphog
dismissed stale reviews from jost-s and mattyg
The base branch was changed.
Merged
ThetaSinner
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does NOT resolve #22 -- this is just a set of stubs that set up what a space might look like.
We've got a chicken/egg problem with getting some of this code in here, and need some concrete bits to be in place to make it easier to do the things around it, like the top-level module or the tx module.