-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport API and StubTransport Test Implementation #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I particularly like the testing with this one and that the traits come with a working and tested implementation so I can see how it all fits together :)
I have left quite a few comments about naming which is quite a pain. They are suggestions only in most cases!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good and is also quite dense. I need to come back to this tomorrow. It's not as second nature to me as it is to you. ;-)
Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com> Co-authored-by: Jost Schulte <28270981+jost-s@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm starting to see how this is coming together. Which may sound as if this is getting to a stage where I wanted it to be, but it rather means that I'm beginning to understand the full picture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, let's go :)
No description provided.