Dht diff #59
Merged
Dht diff #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
force-pushed
the
dht-diff
branch
from
05c1be8 to
21cc5f3
Compare
Open
neonphog
reviewed
Dec 19, 2024
neonphog
reviewed
Dec 19, 2024
neonphog
reviewed
Dec 19, 2024
neonphog
reviewed
Dec 19, 2024
neonphog
reviewed
Dec 19, 2024
neonphog
reviewed
Dec 19, 2024
neonphog
previously approved these changes
Dec 19, 2024
ThetaSinner
force-pushed
the
dht-diff
branch
from
2123b32 to
cf58810
Compare
mattyg
reviewed
Dec 20, 2024
jost-s
reviewed
Dec 21, 2024
jost-s
reviewed
Dec 21, 2024
jost-s
reviewed
Dec 21, 2024
jost-s
approved these changes
Jan 2, 2025
Co-authored-by: Jost <28270981+jost-s@users.noreply.github.com>
Co-authored-by: Jost <28270981+jost-s@users.noreply.github.com>
Co-authored-by: Jost <28270981+jost-s@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top level DHT model and diff comparison to figure out which ops might be missing from the other.
I know there's a lot of code addition on this PR. I think the best place to start is probably the module documentation, then following that into the entry functions like
snapshot_minimal. That should be good for a high-level understanding I hope. Then the test harnesscrates/dht/tests/harness.rsis a good place to understand how the sync is done. That code will be more or less what gossip needs to do to use the code under test.If it helps, there is +1574 just from tests. So only half of this is actually new production code.
Following this PR I think there's a need to go back over the code in this crate and ensure consistent naming and documentation. I think the new documentation is consistent but I don't think it's entirely consistent with what's in here from previous PRs.