Process fetch responses #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor/fetch-improvements
…actor/improve-fetch-back-off-backon
jost-s
force-pushed
the
feat/process-fetch-responses
branch
from
59c92a7 to
153b705
Compare
jost-s
commented
Jan 3, 2025
| @@ -69,6 +70,7 @@ impl PartialOrd for StoredOp { | |||
| } | |||
|
|
|||
| /// The API that a kitsune2 host must implement to provide data persistence for kitsune2. | |||
| #[automock] | |||
There was a problem hiding this comment.
Auto-mocking this trait. I'll refactor the other fetch test files using automock too.
jost-s
force-pushed
the
feat/process-fetch-responses
branch
from
153b705 to
85f839e
Compare
jost-s
force-pushed
the
feat/fetch-response-queue
branch
from
4e00657 to
57b3547
Compare
jost-s
force-pushed
the
feat/process-fetch-responses
branch
from
85f839e to
f338b3a
Compare
jost-s
commented
Jan 3, 2025
| ops: Vec<op_store::MetaOp>, | ||
| ) -> BoxFut<'_, K2Result<()>> { | ||
| Box::pin(async move { | ||
| match self.op_store.process_incoming_ops(ops.clone()).await { |
There was a problem hiding this comment.
I was wondering if there should be some protection against invalid ops or DoS attacks here. But it should probably be in the module that owns the fetch module.
jost-s
force-pushed
the
feat/fetch-response-queue
branch
6 times, most recently
from
a3ee21f to
8631869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process incoming responses to fetch requests. This completes the cycle from sending fetch request -> sending fetch response -> receiving fetch response.
A next step could be an integration test of all three parts.
depends on #63
resolves #62