Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to deal with interruptions at intermediate states during key generation and setup #225

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

matthme
Copy link
Collaborator

@matthme matthme commented Sep 17, 2024

This PR adds logic to deal with cases where the launcher setup fails or gets interrupted by the user at intermediate steps.

Specifically:

  • If Launcher gets started up with lair keystore already initialized but no device seed imported yet, it will prompt for the password chosen in the (partial) setup process earlier and then check for the quickSetupChosen variable in local storage
    • If the variable is present in local storage, then the quick setup is completed automatically
    • If the variable is not present, the user is directed to a special page telling them that they need to complete their setup and can either click on "Finish Advanced Setup" or "Skip and Launch (Quick Setup)". If they choose to finish the advanced setup, they will be routed to step 3 of the advanced setup, without the option to go back to earlier steps of the advanced setup
  • If key generation and/or import fails during the final step of Quick Setup, the user will be re-prompted for the password to be able to re-attempt.

@matthme matthme requested review from snowshiva and c12i September 17, 2024 17:09
@matthme matthme mentioned this pull request Sep 9, 2024
8 tasks
@matthme matthme merged commit 36d70ab into develop Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants