-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: poorly formatted rust code #288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2024
c12i
added
the
ShouldBackport/0.3
This change should be backported to develop-0.3
label
May 20, 2024
matthme
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not go through each replacement one by one but from what I can see it looks like a great imrovement!
c12i
removed
the
ShouldBackport/0.3
This change should be backported to develop-0.3
label
Jun 5, 2024
c12i
added a commit
to c12i/scaffolding
that referenced
this pull request
Jun 5, 2024
* fix: poorly formatted code in coordinator zome * document add_newlines * clearn up coordinators module * clean up integrity module * refactor utils * fix add_newlines * update integrity comments * fix map file calls * fix add_newlines * make add_newlines public/private function agnostic * refactor link-type coordinator * fix remove link handler * fix collection coordinator * clean up entry-type coordinator * fix clippy warnings * refactor link-type coordinator * fix bug scaffolding entry-type with linked_from * fix target_hash_variable * remove unnecessary format usage * remove unnecessary clone * fix validate_delete_result * move comment * fix entry from rcord error message * rename unparse function to unparse_pretty;
c12i
added a commit
that referenced
this pull request
Jun 6, 2024
* fix: poorly formatted rust code (#288) * fix: poorly formatted code in coordinator zome * document add_newlines * clearn up coordinators module * clean up integrity module * refactor utils * fix add_newlines * update integrity comments * fix map file calls * fix add_newlines * make add_newlines public/private function agnostic * refactor link-type coordinator * fix remove link handler * fix collection coordinator * clean up entry-type coordinator * fix clippy warnings * refactor link-type coordinator * fix bug scaffolding entry-type with linked_from * fix target_hash_variable * remove unnecessary format usage * remove unnecessary clone * fix validate_delete_result * move comment * fix entry from rcord error message * rename unparse function to unparse_pretty; * feat: add long disable fast track option to hc scaffold web-app (#293) * add fix to prevent accumulation of dist.zip content (#300) * chore: bump version --------- Co-authored-by: matthme <36768177+matthme@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR replaces all stringified rust code instances with
quote
macro usage in order to allow forunparse
to consistently format all rust code that is generated by scaffolding, as well as improving readability of the code by enabling syntax highlighting of generated code making it easy to catch errors.Closes #282
Closes #246