Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace TryCP with Nomad for running scenarios #136

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

cdunster
Copy link
Contributor

@cdunster cdunster commented Dec 4, 2024

Closes #132

@cdunster cdunster self-assigned this Dec 4, 2024
@cdunster cdunster linked an issue Dec 4, 2024 that may be closed by this pull request
10 tasks
@cdunster cdunster force-pushed the 132-replace-trycp-with-nomad-for-running-scenarios branch from 6207ecb to 412fb29 Compare December 4, 2024 14:36
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out, looking good!

RUST_LOG = "info"
}
config {
command = abspath("result/bin/app_install")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be a way to have this reference a common path locally and remotely so that we can use the same scripts in dev as on a real environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping to allow this but I'm not yet sure what is the best way. I think at the very least it should be possible to provide either a path or a URL and if it's a URL then the binary gets downloaded as an artefact before being run.

"--agents", "2",
"--behaviour", "minimal:1",
"--behaviour", "large:1",
"--duration", "5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this default to a longer time when you're ready to merge this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea (already in the latest version) is that if no duration is provided then it is not actually set and so it will use the default provided by the scenario. This could be an issue for neverending scenarios but I think it makes the most sense and we can always kill a running scenario at set the duration if we miss it by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace TryCP with Nomad for running scenarios
2 participants