RC 0.9.1

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,39 @@
+---
+name: Bug report
+about: Help us stomp out bugs!
+title: ''
+labels: bug
+assignees: ''
+
+---
+
+<!-- If you run into SDK issues, please go [here](https://community.hologram.io/c/hardware/sdk) for help and support:
+-->
+### Describe the problem
+
+
+### Expected behavior
+<!-- Please describe what you think the program should be doing here. -->
+
+
+### Actual behavior
+<!-- Please provide any useful debug logs/output here. This will help us diagnose
+problems that you might have. Full stack traces can be extremely helpful here. -->
+
+
+### Steps to reproduce the behavior
+<!--Please provide the exact command(s) to reproduce the error. If it's non-deterministic,
+try your best to describe your observations that might help us troubleshoot the error. -->
+
+### System information
+- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**:
+- **Python SDK installed via PyPI or GitHub**:
+- **SDK version (use command below)**:
+- **Python version**:
+- **Hardware (modem) model**:
+
+<!--
+We will be adding an environment capture script soon for your convenience.
+
+You can obtain the Python SDK version with:
+`hologram version` -->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: enhancement
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
+
+**Describe the solution you'd like**
+<!-- A clear and concise description of what you want to happen. -->
+
+**Describe alternatives you've considered**
+<!-- A clear and concise description of any alternative solutions or features you've considered. -->
+
+**Additional context**
+<!-- Add any other context or screenshots about the feature request here. -->

.github/changelog-drafter.yml

@@ -0,0 +1,52 @@
+name-template: 'v$RESOLVED_VERSION 🌈'
+
+tag-template: 'v$RESOLVED_VERSION'
+
+categories:
+  - title: '🚀 Features'
+    labels:
+      - 'feature'
+      - 'enhancement'
+  - title: '🐛 Bug Fixes'
+    labels:
+      - 'fix'
+      - 'bugfix'
+      - 'bug'
+  - title: '🧰 Maintenance'
+    labels: 
+      - 'chore'
+      - 'debt'
+  - title: '🛠 Dependency Updates'
+    labels: 
+      - 'dependencies'
+
+change-template: '- $TITLE @$AUTHOR (#$NUMBER)'
+
+version-resolver:
+  major:
+    labels:
+      - 'major'
+      - 'breaking'
+  minor:
+    labels:
+      - 'minor'
+      - 'feature'
+  patch:
+    labels:
+      - 'patch'
+      - 'bugfix'
+      - 'debt'
+      - 'dependencies'
+  default: patch
+
+exclude-labels:
+  - 'skip-changelog'
+
+template: |
+  ## Changes
+
+  $CHANGES
+
+  **Release Date:** <DATE>
+  **Release Engineer:** $CONTRIBUTORS
+  **Previous Release:** $PREVIOUS_TAG

.github/dependabot.yml

@@ -0,0 +1,19 @@
+# Basic dependabot.yml file with
+# minimum configuration for two package managers
+# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+
+  # Maintain dependencies for GitHub Actions
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"
+
+
+  # Enable version updates for python pip
+  - package-ecosystem: "pip"
+    directory: "/"
+    schedule:
+      interval: "daily"

.github/workflows/changelog.yml

@@ -0,0 +1,19 @@
+name: Changelog Drafter
+
+on:
+  push:
+    # develop is our tracking branch
+    branches:
+      - develop
+
+jobs:
+  update_release_draft:
+    runs-on: ubuntu-latest
+    steps:
+      # Drafts your next Release notes as Pull Requests are merged into "master"
+      - uses: release-drafter/release-drafter@v5
+        with:
+          # (Optional) specify config name to use, relative to .github/. Default: release-drafter.yml
+          config-name: changelog-drafter.yml
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/publish.yml

@@ -0,0 +1,26 @@
+name: Upload Python Package
+
+on:
+  release:
+    types: [created]
+
+jobs:
+  deploy:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python
+      uses: actions/setup-python@v2.0.2
+      with:
+        python-version: '3.x'
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install setuptools wheel twine
+    - name: Build and publish
+      env:
+        TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
+        TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
+      run: |
+        python setup.py sdist bdist_wheel
+        twine upload dist/*

.github/workflows/testlint.yml

@@ -0,0 +1,39 @@
+name: Python Test and Lint
+
+on: [push]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: [3.7]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v2
+      with:
+        python-version: ${{ matrix.python-version }}
+
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install -r requirements.txt
+
+    - name: Lint with flake8
+      run: |
+        pip install flake8
+        # stop the build if there are Python syntax errors or undefined names
+        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+
+    - name: Test with coverage and coveralls
+      env:
+        COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
+      run: |
+        pip install coveralls pytest-cov
+        pytest --cov=Hologram tests/
+        coveralls

Hologram/Api/Api.py

@@ -14,7 +14,7 @@
 
 HOLOGRAM_REST_API_BASEURL = 'https://dashboard.hologram.io/api/1'
 
-class Api():
+class Api:
 
     def __init__(self, apikey='', username='', password=''):
         # Logging setup.

Hologram/Authentication/AES/AESCipher.py

@@ -12,7 +12,7 @@
 from cryptography.hazmat.primitives import padding
 from cryptography.hazmat.backends import default_backend
 
-class AESCipher():
+class AESCipher:
 
     # EFFECTS: Constructor that sets the IV to
     def __init__(self, iv, key):

Hologram/Authentication/Authentication.py

@@ -10,7 +10,7 @@
 import logging
 from logging import NullHandler
 
-class Authentication():
+class Authentication:
 
     def __init__(self, credentials):
         self.credentials = credentials

Hologram/Cloud.py

@@ -15,7 +15,7 @@
 
 __version__ = '0.9.0'
 
-class Cloud():
+class Cloud:
 
     def __repr__(self):
         return type(self).__name__

Hologram/CustomCloud.py

@@ -302,6 +302,7 @@ def acceptIncomingConnection(self):
             self._receive_cv.acquire()
 
             if self.socketClose:
+                self.logger.debug('Closing socket connection')
                 self._receive_cv.release()
                 break
 
@@ -325,22 +326,23 @@ def __incoming_connection_thread(self, clientsocket):
         clientsocket.settimeout(RECEIVE_TIMEOUT)
 
         # Keep parsing the received data until timeout or receive no more data.
-        recv = ''
+        recv = b''
         while True:
             try:
                 result = clientsocket.recv(MAX_RECEIVE_BYTES)
+                self.logger.debug('Received message: %s', result)
             except socket.timeout:
                 break
             if not result:
                 break
             recv += result
 
-        self.logger.info('Received message: %s', recv)
+        self.logger.info('Received message: %s', recv.decode())
 
         self._receive_buffer_lock.acquire()
 
         # Append received message into receive buffer
-        self._receive_buffer.append(recv)
+        self._receive_buffer.append(recv.decode())
         self.logger.debug('Receive buffer: %s', self._receive_buffer)
 
         self._receive_buffer_lock.release()

Hologram/Event/Event.py

@@ -8,7 +8,7 @@
 # LICENSE: Distributed under the terms of the MIT License
 import logging
 
-class Event():
+class Event:
     _funcLookupTable = {}
     def __init__(self):
         self.__dict__ = self._funcLookupTable

Hologram/HologramCloud.py

@@ -186,7 +186,10 @@ def popReceivedSMS(self):
     def __parse_hologram_json_result(self, result):
         try:
             resultList = json.loads(result)
-            resultList[0] = int(resultList[0])
+            if isinstance(resultList, bytes):
+                resultList[0] = int(chr(resultList[0]))
+            else:
+                resultList[0] = int(resultList[0])
         except ValueError:
             self.logger.error('Server replied with invalid JSON [%s]', result)
             resultList = [ERR_UNKNOWN]
@@ -200,8 +203,12 @@ def __parse_hologram_compact_result(self, result):
             return [ERR_UNKNOWN]
 
         resultList = []
-        for x in result:
-            resultList.append(int(x))
+        if isinstance(result, bytes):
+            for x in result:
+                resultList.append(int(chr(x)))
+        else:
+            for x in result:
+                resultList.append(int(x))
 
         if len(resultList) == 0:
             resultList = [ERR_UNKNOWN]