Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build dependency checks. #48

Merged
merged 1 commit into from
Jul 7, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,26 +1,7 @@
from setuptools import setup
####
# Build dependency checks
#
# Temporary, until pyproject.toml is widely supported. We're expecting
# most users to install a wheel or conda package, neither of which
# requires running setup.py and building a package. So these checks
# are for packagers and those installing from e.g. github.
import setuptools
from pkg_resources import parse_version
missing_build_dep = False
if parse_version(setuptools.__version__)<parse_version('30.3.0'):
missing_build_dep = True
try:
import param
if parse_version(param.__version__)<parse_version('1.7.0'):
missing_build_dep = True
except:
missing_build_dep = True

if missing_build_dep:
raise ValueError('Building pyct requires setuptools>=30.3.0 and param>=1.7.0; please upgrade to pip>=10 and try again. Alternatively, install the build dependencies manually first (e.g. `pip install --upgrade "setuptools>=30.3.0" "param>=1.7.0"` or `conda install -c pyviz "setuptools>=30.3.0" "param>=1.7.0"`)')
#####
# TODO: need to put in build dependency checks until pyproject.toml is widely
# supported.

if __name__ == "__main__":
setup()