Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSS for interactivity warning option #16

Merged
merged 4 commits into from
Dec 10, 2020

Conversation

jlstevens
Copy link

@jlstevens jlstevens commented Nov 11, 2020

Fairly ugly right now and will be improved. Right now the goal is to show what is necessary for the interactivity warning PR (holoviz-dev/nbsite#191) on nbsite.

@jlstevens
Copy link
Author

Here are some screenshot of what it looks like against the current version of holoviz-dev/nbsite#191:

Full width:

Squashed to approx. half the screen:

I think it is serviceable now but happy to take any suggestions @jbednar @philippjfr !

@jbednar
Copy link

jbednar commented Nov 18, 2020

Looks good. Maybe make the font size a little smaller so that it doesn't stretch out so much when squashed? Will the warning stay on the screen the whole time, after a user scrolls down?

@jlstevens
Copy link
Author

Will the warning stay on the screen the whole time, after a user scrolls down?

Yes. Here is an example:

Maybe make the font size a little smaller so that it doesn't stretch out so much when squashed

Sure though as a warning it should still be easy to read. Right now the CSS isn't specifying anything about the font size so I'll have to find what the default is and then pick something smaller.

@jbednar
Copy link

jbednar commented Nov 18, 2020

Ok, if it's always there, sounds perfect!

Can't you just set it to smaller?

@jlstevens
Copy link
Author

Here it is using smaller:

image

@jbednar
Copy link

jbednar commented Nov 18, 2020

Looks good to me!

@jlstevens
Copy link
Author

I'll go ahead and merge and test with an nbsite dev release.

@jlstevens jlstevens merged commit 52b7a56 into master Dec 10, 2020
@philippjfr
Copy link

Why was this added to the theme and not the nbsite.css?

@jlstevens
Copy link
Author

It could have gone either way...the interactivity warning seemed to be more of a holoviz preference than an nbsite preference but seeing as the option to enable/disable it is at the nbsite level, that point is rather moot. If you wish to move this CSS to nbsite.css (and it works!) then that is fine with me.

@philippjfr
Copy link

Not totally straightforward as you say, it does need adjusting depending on the theme. But it is very surprising for the warning to show up at the bottom of the page instead of floating when using another theme.

@jlstevens
Copy link
Author

I suppose I didn't consider this option being used with other themes (or at least other themes without this bit of CSS added). I'm happy for this CSS to be moved to nbsite.css instead.

@jlstevens
Copy link
Author

jlstevens commented Apr 6, 2021

I guess the nicest thing would be globally sensible options in nbsite.css (such as the floating option you mention) and any other necessary tweaks added at the theme level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants