Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing symlink creation on GH Actions #134

Merged
merged 6 commits into from
Jan 29, 2021
Merged

Fixing symlink creation on GH Actions #134

merged 6 commits into from
Jan 29, 2021

Conversation

jlstevens
Copy link
Contributor

The symlinks are necessary to allow the shortened URLs on examples.pyviz. Creation was working on Travis but no longer seems to be working on GH Actions. The public website can be fixed by manually pushing the symlinks to gh-pages but that is easily forgotten and not a long term solution.

@jlstevens
Copy link
Contributor Author

I now think the symlink creation is fine and it is the crazy-max/ghaction-github-pages step that is complaining.

Probably related to this issue: crazy-max/ghaction-github-pages#130

@jlstevens
Copy link
Contributor Author

jlstevens commented Jan 29, 2021

@jbednar I am exploring a non-symlink based approach to redirecting with pages like this:

<!DOCTYPE html>
<html>
   <head>
      <title>Square Limit Redirect</title>
      <meta http-equiv = "refresh" content = "0; url = https://examples.pyviz.org/square_limit/square_limit.html" />
   </head>
   <body>
      <p>Redirecting...</p>
   </body>
</html>

Right now you can test this approach here. I have now removed the body above so you don't see the text before the redirect occurs.

I'll obviously have to update dodo.py to use this if I can't figure out how to get the symlinks working again soon.

@jlstevens
Copy link
Contributor Author

This change has been successfully deployed to https://examples.pyviz.org/.

One way in which symlinks were better is the URL didn't change when using the short URL. For instance, if you enter https://examples.pyviz.org/ship_traffic/ you get directed to https://examples.pyviz.org/ship_traffic/ship_traffic.html. This doesn't seem too bad and it is a lot better than broken links so I'll go ahead and merge. We can try to figure out how to get the symlinks updated on gh-pages in a separate PR.

@jlstevens jlstevens merged commit d85de1c into master Jan 29, 2021
@philippjfr philippjfr deleted the symlink_fix branch January 21, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant