-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichannel Timeseries #418
Conversation
droumis
commented
Aug 29, 2024
•
edited
Loading
edited
Your changes were successfully integrated in the dev site, make sure to review |
1 similar comment
Your changes were successfully integrated in the dev site, make sure to review |
Just noting that for the multichan.ipynb, I'm having to use an Overlay instead of e.g. |
Note: Check to ensure that the resultant downsampled data pyramid doesn't ever live entirely in memory prior to getting written to disk. |
Note: find better principled way to determine factors for creating the data pyramids.. |
Your changes were successfully integrated in the dev site, make sure to review |
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
" print(f'Pyramid Already Exists: {PYRAMID_PATH}')" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the bottom of this cell is a good place to add f.close()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f is only used in conversion to xarray. I added a context manager instead of f.close()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arf now I get this error when the pyramid gets created, while I don't when close
is called afterwards. I'll make the change.
OSError: Can't synchronously read data (dset_id is not a dataset ID)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some unresolved comments, specially for the large_multichan notebook.
@maximlt, I think I've addressed everything identified up until now. Sorry for not seeing some of the previous review comments until recently. Thanks for the epic review! |
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
We got well over-trained to do this last year with the NF SDF grant! Thanks for adjusting the example based on our feedback, it's such a cool one. It should totally be in the Featured section, except that I think keeping 8 examples there sounds reasonable and I didn't which one to remove, so that's for later :) Merging, congrats! |
I agree that 8 is the max for that section. It's a very tough call; those are all very cool examples, but if I think about what they demonstrate, this example covers things not included there at all, so I do think it should bump something out. I'd guess we should replace Exoplanets in that group, given that it's not currently showing any plots (which is maybe an error?). |