Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check to use matplotlib version instead of python version #104

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 19, 2023

Fixes #103

The test would fail when having matplotlib version 3.4 and below installed.

@hoxbro hoxbro requested a review from jbednar January 19, 2023 12:47
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!!

@jbednar jbednar merged commit 334b770 into main Jan 19, 2023
@jbednar jbednar deleted the fix_old_matplotlib_version_test branch January 19, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Over 300 test failures for =dev-python/colorcet-2.0.6
2 participants