ci: Move numba to top of dependencies #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
=======================================
Coverage 88.57% 88.57%
=======================================
Files 93 93
Lines 18644 18644
=======================================
Hits 16514 16514
Misses 2130 2130 ☔ View full report in Codecov by Sentry. |
maximlt
reviewed
Oct 29, 2024
| @@ -22,10 +22,10 @@ build = ["py311", "build"] | |||
| lint = ["py311", "lint"] | |||
|
|
|||
| [dependencies] | |||
| numba = "*" # At top as this dictates Python version | |||
There was a problem hiding this comment.
The order of the dependencies has some influence?
There was a problem hiding this comment.
This is because it would not solve on osx-64, see conda/rattler#913.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will not solve on
osx-64because it is in a weird state betweennumbaandpython 3.13