Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shapely 2 support #603

Merged
merged 11 commits into from
Jan 4, 2023
Merged

shapely 2 support #603

merged 11 commits into from
Jan 4, 2023

Conversation

@hoxbro
Copy link
Member Author

hoxbro commented Dec 15, 2022

The only problem left with the upgrade is that this no longer works:

import geoviews as gv
import geoviews.feature as gf
import xarray as xr
from cartopy import crs

gv.extension('bokeh')
gf.land.opts(projection=crs.Geostationary())

Where these work gf.land.opts(projection=crs.Geostationary(), scale="10m") and gf.land. Another problem is that opts are saved on the FeaturePlot even if you instantiate it.

@hoxbro hoxbro changed the title Try to run test with shapely 2 shapely 2 support Dec 15, 2022
@hoxbro hoxbro added this to the Version 1.9.6 milestone Jan 2, 2023
@hoxbro
Copy link
Member Author

hoxbro commented Jan 3, 2023

The last two commit (9eb60be and f12a1b3) fixes the last of the problems I mentioned in the previous post.

import geoviews as gv
import geoviews.feature as gf
from cartopy import crs

gv.extension('bokeh')
(gf.land().opts(projection=crs.Geostationary()) + gf.land()).opts(shared_axes=False)

Before:
 Screenshot 2023-01-03 21 59 06

After:
 Screenshot 2023-01-03 21 58 37

@hoxbro hoxbro requested a review from philippjfr January 3, 2023 21:07
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hoxbro! Pretty happy the changes look pretty minimal and all look good to me.

@hoxbro hoxbro merged commit 0a099b5 into main Jan 4, 2023
@hoxbro hoxbro deleted the test_shapely2 branch January 4, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix last shapely 2 issue Fix all the shapely deprecation warnings before shapely 2 is released
2 participants