-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rioxarray support #645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; just left a few nits about readability!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; just one suggestion for adding a test.
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
Thank you for the review will merge when the test passes 👍 |
No problem, happy to review! |
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
Fixes #644
Rioxarray
da.coords
containsspatial_ref
with is not a dimension. This makes it go down the wrong code path. By only usingda.coords.dims
, we can make it go down the same code path as previously.I also aligned
process_crs
with the recent changes in hvplot's version of it in holoviz/hvplot#1026. Though I added+init
to the string comparison to avoid this warning:At last, I added simple crs detection for a rioxarray and updated
param.main.warning
towarn
as it no longer exits.These changes make it possible to run the original example like this: