-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max zoom default #745
Merged
Merged
Add max zoom default #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To only change diff --git a/geoviews/plotting/bokeh/__init__.py b/geoviews/plotting/bokeh/__init__.py
index 6a2c16c..6956152 100644
--- a/geoviews/plotting/bokeh/__init__.py
+++ b/geoviews/plotting/bokeh/__init__.py
@@ -49,7 +49,7 @@ from ...operation import (
project_quadmesh,
project_vectorfield,
)
-from ...tile_sources import _ATTRIBUTIONS
+from ...tile_sources import _ATTRIBUTIONS, OSM
from ...util import line_types, poly_types
from . import callbacks # noqa
from .plot import GeoOverlayPlot, GeoPlot
@@ -60,6 +60,9 @@ except ImportError:
class ImageStackPlot:
...
+_TILE_MAX_ZOOM = {OSM: 19}
+
+
class TilePlot(GeoPlot):
style_opts = [
@@ -102,6 +105,8 @@ class TilePlot(GeoPlot):
'Must contain {X}/{Y}/{Z}, {XMIN}/{XMAX}/{YMIN}/{YMAX} '
'or {Q} template strings.')
params = {'url': element.data}
+ if element in _TILE_MAX_ZOOM:
+ params['max_zoom'] = _TILE_MAX_ZOOM[element]
for zoom in ('min_zoom', 'max_zoom'):
if zoom in style:
params[zoom] = style[zoom] |
ahuang11
commented
Sep 9, 2024
hoxbro
reviewed
Sep 9, 2024
hoxbro
approved these changes
Sep 9, 2024
Test will fail due to rc mismatch, but tested the new test and it's ready to merge (I don't have permissions) and added to the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #744
Unfortunately, I couldn't target OSM specifically; all the combinations I tried: