Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from #2439 (and #2091), where I'm testing a notebook flake checking tool.
My current dev version (which is supposed to handle hv opts now too) finds the following minor flakes in the examples directory:
I've 'fixed' these in this PR (except for the last one, which is discussed in one of the previous PRs, and which is a general pyflakes issue).
However, I'm as much testing the flake checking tool as I am looking for hv flakes, so the changes should definitely be inspected. (And in one case I removed an unused variable that was maybe part of the text flow.)
Flakes are supposed to be only things like unused imports and undefined names, which to me means things that would confuse me as a reader - and which I always want someone to remove before I see their code. So I am quite happy for flakes to be errors. But nbsmoke also has an '--only-warn' option, so flakes are just reported by pytest as warnings instead.