Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed some notebook flakes #2690

Merged
merged 1 commit into from
May 16, 2018
Merged

Addressed some notebook flakes #2690

merged 1 commit into from
May 16, 2018

Conversation

ceball
Copy link
Member

@ceball ceball commented May 16, 2018

Follows on from #2439 (and #2091), where I'm testing a notebook flake checking tool.

My current dev version (which is supposed to handle hv opts now too) finds the following minor flakes in the examples directory:

$ pytest --nbsmoke-lint -k ".ipynb" examples
======================================================== test session starts =========================================================
platform linux -- Python 3.6.4, pytest-3.5.1, py-1.5.3, pluggy-0.6.0
rootdir: /scratch/holoviews, inifile:
plugins: nbsmoke-0.2.6+g68f61cf.dirty
collected 239 items                                                                                                                  

examples/gallery/demos/bokeh/area_chart.ipynb .                                                                                [  0%]
examples/gallery/demos/bokeh/autompg_histogram.ipynb F                                                                         [  0%]
examples/gallery/demos/bokeh/autompg_violins.ipynb F                                                                           [  1%]
examples/gallery/demos/bokeh/bachelors_degrees_by_gender.ipynb F                                                               [  1%]
examples/gallery/demos/bokeh/bars_economic.ipynb F                                                                             [  2%]
examples/gallery/demos/bokeh/box_draw_roi_editor.ipynb .                                                                       [  2%]
examples/gallery/demos/bokeh/boxplot_chart.ipynb F                                                                             [  2%]
examples/gallery/demos/bokeh/dot_example.ipynb F                                                                               [  3%]
examples/gallery/demos/bokeh/dragon_curve.ipynb .                                                                              [  3%]
examples/gallery/demos/bokeh/dropdown_economic.ipynb F                                                                         [  4%]
examples/gallery/demos/bokeh/emoji_tsne.ipynb .                                                                                [  4%]
examples/gallery/demos/bokeh/energy_sankey.ipynb .                                                                             [  5%]
examples/gallery/demos/bokeh/hextile_movie_ratings.ipynb F                                                                     [  5%]
examples/gallery/demos/bokeh/histogram_example.ipynb .                                                                         [  5%]
examples/gallery/demos/bokeh/iris_density_grid.ipynb F                                                                         [  6%]
examples/gallery/demos/bokeh/iris_example.ipynb F                                                                              [  6%]
examples/gallery/demos/bokeh/iris_grouped_grid.ipynb F                                                                         [  7%]
examples/gallery/demos/bokeh/iris_splom_example.ipynb F                                                                        [  7%]
examples/gallery/demos/bokeh/irregular_quadmesh.ipynb .                                                                        [  7%]
examples/gallery/demos/bokeh/legend_example.ipynb .                                                                            [  8%]
examples/gallery/demos/bokeh/lesmis_example.ipynb .                                                                            [  8%]
examples/gallery/demos/bokeh/lorenz_attractor_example.ipynb .                                                                  [  9%]
examples/gallery/demos/bokeh/mandelbrot_section.ipynb .                                                                        [  9%]
examples/gallery/demos/bokeh/measles_example.ipynb .                                                                           [ 10%]
examples/gallery/demos/bokeh/network_graph.ipynb .                                                                             [ 10%]
examples/gallery/demos/bokeh/nyc_radial_heatmap.ipynb .                                                                        [ 10%]
examples/gallery/demos/bokeh/point_draw_triangulate.ipynb F                                                                    [ 11%]
examples/gallery/demos/bokeh/quiver_demo.ipynb .                                                                               [ 11%]
examples/gallery/demos/bokeh/route_chord.ipynb F                                                                               [ 12%]
examples/gallery/demos/bokeh/scatter_economic.ipynb F                                                                          [ 12%]
examples/gallery/demos/bokeh/square_limit.ipynb .                                                                              [ 12%]
examples/gallery/demos/bokeh/step_chart.ipynb F                                                                                [ 13%]
examples/gallery/demos/bokeh/stocks_example.ipynb .                                                                            [ 13%]
examples/gallery/demos/bokeh/texas_choropleth_example.ipynb F                                                                  [ 14%]
examples/gallery/demos/bokeh/topographic_hillshading.ipynb F                                                                   [ 14%]
examples/gallery/demos/bokeh/us_unemployment.ipynb .                                                                           [ 15%]
examples/gallery/demos/bokeh/verhulst_mandelbrot.ipynb .                                                                       [ 15%]
examples/gallery/demos/matplotlib/area_chart.ipynb .                                                                           [ 15%]
examples/gallery/demos/matplotlib/autompg_histogram.ipynb F                                                                    [ 16%]
examples/gallery/demos/matplotlib/autompg_violins.ipynb F                                                                      [ 16%]
examples/gallery/demos/matplotlib/bachelors_degrees_by_gender.ipynb F                                                          [ 17%]
examples/gallery/demos/matplotlib/bars_economic.ipynb F                                                                        [ 17%]
examples/gallery/demos/matplotlib/boxplot_chart.ipynb F                                                                        [ 17%]
examples/gallery/demos/matplotlib/dragon_curve.ipynb .                                                                         [ 18%]
examples/gallery/demos/matplotlib/dropdown_economic.ipynb F                                                                    [ 18%]
examples/gallery/demos/matplotlib/energy_sankey.ipynb .                                                                        [ 19%]
examples/gallery/demos/matplotlib/hextile_movie_ratings.ipynb F                                                                [ 19%]
examples/gallery/demos/matplotlib/histogram_example.ipynb .                                                                    [ 20%]
examples/gallery/demos/matplotlib/iris_density_grid.ipynb F                                                                    [ 20%]
examples/gallery/demos/matplotlib/iris_example.ipynb F                                                                         [ 20%]
examples/gallery/demos/matplotlib/iris_grouped_grid.ipynb F                                                                    [ 21%]
examples/gallery/demos/matplotlib/iris_splom_example.ipynb F                                                                   [ 21%]
examples/gallery/demos/matplotlib/irregular_quadmesh.ipynb .                                                                   [ 22%]
examples/gallery/demos/matplotlib/legend_example.ipynb .                                                                       [ 22%]
examples/gallery/demos/matplotlib/lorenz_attractor_example.ipynb .                                                             [ 23%]
examples/gallery/demos/matplotlib/mandelbrot_section.ipynb .                                                                   [ 23%]
examples/gallery/demos/matplotlib/measles_example.ipynb .                                                                      [ 23%]
examples/gallery/demos/matplotlib/network_graph.ipynb .                                                                        [ 24%]
examples/gallery/demos/matplotlib/nyc_radial_heatmap.ipynb .                                                                   [ 24%]
examples/gallery/demos/matplotlib/polar_scatter_demo.ipynb .                                                                   [ 25%]
examples/gallery/demos/matplotlib/quiver_demo.ipynb .                                                                          [ 25%]
examples/gallery/demos/matplotlib/route_chord.ipynb F                                                                          [ 25%]
examples/gallery/demos/matplotlib/scatter_economic.ipynb F                                                                     [ 26%]
examples/gallery/demos/matplotlib/square_limit.ipynb .                                                                         [ 26%]
examples/gallery/demos/matplotlib/step_chart.ipynb F                                                                           [ 27%]
examples/gallery/demos/matplotlib/stocks_example.ipynb .                                                                       [ 27%]
examples/gallery/demos/matplotlib/surface_3d.ipynb .                                                                           [ 28%]
examples/gallery/demos/matplotlib/texas_choropleth_example.ipynb F                                                             [ 28%]
examples/gallery/demos/matplotlib/topographic_hillshading.ipynb F                                                              [ 28%]
examples/gallery/demos/matplotlib/trisurf3d_demo.ipynb .                                                                       [ 29%]
examples/gallery/demos/matplotlib/us_unemployment.ipynb .                                                                      [ 29%]
examples/gallery/demos/matplotlib/verhulst_mandelbrot.ipynb .                                                                  [ 30%]
examples/gallery/demos/plotly/surface_3d.ipynb .                                                                               [ 30%]
examples/gallery/demos/plotly/trisurf3d_demo.ipynb .                                                                           [ 30%]
examples/getting_started/1-Introduction.ipynb .                                                                                [ 31%]
examples/getting_started/2-Customization.ipynb .                                                                               [ 31%]
examples/getting_started/3-Tabular_Datasets.ipynb .                                                                            [ 32%]
examples/getting_started/4-Gridded_Datasets.ipynb .                                                                            [ 32%]
examples/getting_started/5-Live_Data.ipynb .                                                                                   [ 33%]
examples/reference/containers/bokeh/DynamicMap.ipynb .                                                                         [ 33%]
examples/reference/containers/bokeh/GridSpace.ipynb .                                                                          [ 33%]
examples/reference/containers/bokeh/HoloMap.ipynb .                                                                            [ 34%]
examples/reference/containers/bokeh/Layout.ipynb .                                                                             [ 34%]
examples/reference/containers/bokeh/NdLayout.ipynb .                                                                           [ 35%]
examples/reference/containers/bokeh/NdOverlay.ipynb .                                                                          [ 35%]
examples/reference/containers/bokeh/Overlay.ipynb .                                                                            [ 35%]
examples/reference/containers/matplotlib/DynamicMap.ipynb .                                                                    [ 36%]
examples/reference/containers/matplotlib/GridSpace.ipynb .                                                                     [ 36%]
examples/reference/containers/matplotlib/HoloMap.ipynb .                                                                       [ 37%]
examples/reference/containers/matplotlib/Layout.ipynb .                                                                        [ 37%]
examples/reference/containers/matplotlib/NdLayout.ipynb .                                                                      [ 38%]
examples/reference/containers/matplotlib/NdOverlay.ipynb .                                                                     [ 38%]
examples/reference/containers/matplotlib/Overlay.ipynb .                                                                       [ 38%]
examples/reference/elements/bokeh/Area.ipynb .                                                                                 [ 39%]
examples/reference/elements/bokeh/Arrow.ipynb .                                                                                [ 39%]
examples/reference/elements/bokeh/Bars.ipynb .                                                                                 [ 40%]
examples/reference/elements/bokeh/Bivariate.ipynb .                                                                            [ 40%]
examples/reference/elements/bokeh/Bounds.ipynb F                                                                               [ 41%]
examples/reference/elements/bokeh/Box.ipynb .                                                                                  [ 41%]
examples/reference/elements/bokeh/BoxWhisker.ipynb .                                                                           [ 41%]
examples/reference/elements/bokeh/Chord.ipynb F                                                                                [ 42%]
examples/reference/elements/bokeh/Contours.ipynb .                                                                             [ 42%]
examples/reference/elements/bokeh/Curve.ipynb .                                                                                [ 43%]
examples/reference/elements/bokeh/Distribution.ipynb .                                                                         [ 43%]
examples/reference/elements/bokeh/Div.ipynb .                                                                                  [ 43%]
examples/reference/elements/bokeh/Ellipse.ipynb .                                                                              [ 44%]
examples/reference/elements/bokeh/ErrorBars.ipynb .                                                                            [ 44%]
examples/reference/elements/bokeh/Graph.ipynb F                                                                                [ 45%]
examples/reference/elements/bokeh/HLine.ipynb .                                                                                [ 45%]
examples/reference/elements/bokeh/HSV.ipynb .                                                                                  [ 46%]
examples/reference/elements/bokeh/HeatMap.ipynb .                                                                              [ 46%]
examples/reference/elements/bokeh/HexTiles.ipynb .                                                                             [ 46%]
examples/reference/elements/bokeh/Histogram.ipynb .                                                                            [ 47%]
examples/reference/elements/bokeh/Image.ipynb .                                                                                [ 47%]
examples/reference/elements/bokeh/ItemTable.ipynb F                                                                            [ 48%]
examples/reference/elements/bokeh/Labels.ipynb .                                                                               [ 48%]
examples/reference/elements/bokeh/Path.ipynb .                                                                                 [ 48%]
examples/reference/elements/bokeh/Points.ipynb .                                                                               [ 49%]
examples/reference/elements/bokeh/Polygons.ipynb .                                                                             [ 49%]
examples/reference/elements/bokeh/QuadMesh.ipynb .                                                                             [ 50%]
examples/reference/elements/bokeh/RGB.ipynb .                                                                                  [ 50%]
examples/reference/elements/bokeh/RadialHeatMap.ipynb .                                                                        [ 51%]
examples/reference/elements/bokeh/Raster.ipynb .                                                                               [ 51%]
examples/reference/elements/bokeh/Sankey.ipynb F                                                                               [ 51%]
examples/reference/elements/bokeh/Scatter.ipynb .                                                                              [ 52%]
examples/reference/elements/bokeh/Spikes.ipynb .                                                                               [ 52%]
examples/reference/elements/bokeh/Spline.ipynb F                                                                               [ 53%]
examples/reference/elements/bokeh/Spread.ipynb .                                                                               [ 53%]
examples/reference/elements/bokeh/Table.ipynb F                                                                                [ 53%]
examples/reference/elements/bokeh/Text.ipynb .                                                                                 [ 54%]
examples/reference/elements/bokeh/TriMesh.ipynb F                                                                              [ 54%]
examples/reference/elements/bokeh/VLine.ipynb .                                                                                [ 55%]
examples/reference/elements/bokeh/VectorField.ipynb .                                                                          [ 55%]
examples/reference/elements/bokeh/Violin.ipynb .                                                                               [ 56%]
examples/reference/elements/matplotlib/Area.ipynb .                                                                            [ 56%]
examples/reference/elements/matplotlib/Arrow.ipynb .                                                                           [ 56%]
examples/reference/elements/matplotlib/Bars.ipynb .                                                                            [ 57%]
examples/reference/elements/matplotlib/Bivariate.ipynb .                                                                       [ 57%]
examples/reference/elements/matplotlib/Bounds.ipynb F                                                                          [ 58%]
examples/reference/elements/matplotlib/Box.ipynb .                                                                             [ 58%]
examples/reference/elements/matplotlib/BoxWhisker.ipynb .                                                                      [ 58%]
examples/reference/elements/matplotlib/Chord.ipynb F                                                                           [ 59%]
examples/reference/elements/matplotlib/Contours.ipynb .                                                                        [ 59%]
examples/reference/elements/matplotlib/Curve.ipynb .                                                                           [ 60%]
examples/reference/elements/matplotlib/Distribution.ipynb .                                                                    [ 60%]
examples/reference/elements/matplotlib/Ellipse.ipynb .                                                                         [ 61%]
examples/reference/elements/matplotlib/ErrorBars.ipynb .                                                                       [ 61%]
examples/reference/elements/matplotlib/Graph.ipynb F                                                                           [ 61%]
examples/reference/elements/matplotlib/HLine.ipynb .                                                                           [ 62%]
examples/reference/elements/matplotlib/HSV.ipynb .                                                                             [ 62%]
examples/reference/elements/matplotlib/HeatMap.ipynb .                                                                         [ 63%]
examples/reference/elements/matplotlib/HexTiles.ipynb .                                                                        [ 63%]
examples/reference/elements/matplotlib/Histogram.ipynb .                                                                       [ 64%]
examples/reference/elements/matplotlib/Image.ipynb .                                                                           [ 64%]
examples/reference/elements/matplotlib/ItemTable.ipynb F                                                                       [ 64%]
examples/reference/elements/matplotlib/Labels.ipynb .                                                                          [ 65%]
examples/reference/elements/matplotlib/Path.ipynb .                                                                            [ 65%]
examples/reference/elements/matplotlib/Points.ipynb .                                                                          [ 66%]
examples/reference/elements/matplotlib/Polygons.ipynb .                                                                        [ 66%]
examples/reference/elements/matplotlib/QuadMesh.ipynb .                                                                        [ 66%]
examples/reference/elements/matplotlib/RGB.ipynb .                                                                             [ 67%]
examples/reference/elements/matplotlib/RadialHeatMap.ipynb .                                                                   [ 67%]
examples/reference/elements/matplotlib/Raster.ipynb .                                                                          [ 68%]
examples/reference/elements/matplotlib/Sankey.ipynb F                                                                          [ 68%]
examples/reference/elements/matplotlib/Scatter.ipynb .                                                                         [ 69%]
examples/reference/elements/matplotlib/Scatter3D.ipynb .                                                                       [ 69%]
examples/reference/elements/matplotlib/Spikes.ipynb .                                                                          [ 69%]
examples/reference/elements/matplotlib/Spline.ipynb F                                                                          [ 70%]
examples/reference/elements/matplotlib/Spread.ipynb .                                                                          [ 70%]
examples/reference/elements/matplotlib/Surface.ipynb .                                                                         [ 71%]
examples/reference/elements/matplotlib/Table.ipynb F                                                                           [ 71%]
examples/reference/elements/matplotlib/Text.ipynb .                                                                            [ 71%]
examples/reference/elements/matplotlib/TriMesh.ipynb F                                                                         [ 72%]
examples/reference/elements/matplotlib/TriSurface.ipynb .                                                                      [ 72%]
examples/reference/elements/matplotlib/VLine.ipynb .                                                                           [ 73%]
examples/reference/elements/matplotlib/VectorField.ipynb .                                                                     [ 73%]
examples/reference/elements/matplotlib/Violin.ipynb .                                                                          [ 74%]
examples/reference/elements/plotly/BoxWhiskers.ipynb .                                                                         [ 74%]
examples/reference/elements/plotly/Curve.ipynb .                                                                               [ 74%]
examples/reference/elements/plotly/Distribution.ipynb .                                                                        [ 75%]
examples/reference/elements/plotly/ErrorBars.ipynb .                                                                           [ 75%]
examples/reference/elements/plotly/HeatMap.ipynb .                                                                             [ 76%]
examples/reference/elements/plotly/Image.ipynb .                                                                               [ 76%]
examples/reference/elements/plotly/ItemTable.ipynb F                                                                           [ 76%]
examples/reference/elements/plotly/Points.ipynb .                                                                              [ 77%]
examples/reference/elements/plotly/Raster.ipynb .                                                                              [ 77%]
examples/reference/elements/plotly/Scatter.ipynb .                                                                             [ 78%]
examples/reference/elements/plotly/Scatter3D.ipynb .                                                                           [ 78%]
examples/reference/elements/plotly/Surface.ipynb .                                                                             [ 79%]
examples/reference/elements/plotly/Table.ipynb F                                                                               [ 79%]
examples/reference/elements/plotly/TriSurface.ipynb .                                                                          [ 79%]
examples/reference/features/bokeh/table_hooks_example.ipynb F                                                                  [ 80%]
examples/reference/streams/bokeh/Bounds.ipynb .                                                                                [ 80%]
examples/reference/streams/bokeh/BoundsX.ipynb .                                                                               [ 81%]
examples/reference/streams/bokeh/BoundsY.ipynb .                                                                               [ 81%]
examples/reference/streams/bokeh/BoxEdit.ipynb F                                                                               [ 82%]
examples/reference/streams/bokeh/PointDraw.ipynb F                                                                             [ 82%]
examples/reference/streams/bokeh/PointerX.ipynb F                                                                              [ 82%]
examples/reference/streams/bokeh/PointerXY.ipynb .                                                                             [ 83%]
examples/reference/streams/bokeh/PolyDraw.ipynb F                                                                              [ 83%]
examples/reference/streams/bokeh/PolyEdit.ipynb .                                                                              [ 84%]
examples/reference/streams/bokeh/RangeXY.ipynb F                                                                               [ 84%]
examples/reference/streams/bokeh/Selection1D.ipynb .                                                                           [ 84%]
examples/reference/streams/bokeh/Selection1D_paired.ipynb .                                                                    [ 85%]
examples/reference/streams/bokeh/Selection1D_points.ipynb .                                                                    [ 85%]
examples/reference/streams/bokeh/Selection1D_tap.ipynb .                                                                       [ 86%]
examples/reference/streams/bokeh/Tap.ipynb F                                                                                   [ 86%]
examples/topics/geometry/lsystems.ipynb .                                                                                      [ 87%]
examples/topics/geometry/square_limit.ipynb .                                                                                  [ 87%]
examples/topics/simulation/boids.ipynb .                                                                                       [ 87%]
examples/topics/simulation/hipster_dynamics.ipynb .                                                                            [ 88%]
examples/topics/simulation/sri_model.ipynb F                                                                                   [ 88%]
examples/user_guide/01-Annotating_Data.ipynb .                                                                                 [ 89%]
examples/user_guide/02-Composing_Elements.ipynb .                                                                              [ 89%]
examples/user_guide/03-Customizing_Plots.ipynb .                                                                               [ 89%]
examples/user_guide/04-Dimensioned_Containers.ipynb .                                                                          [ 90%]
examples/user_guide/05-Building_Composite_Objects.ipynb .                                                                      [ 90%]
examples/user_guide/06-Live_Data.ipynb .                                                                                       [ 91%]
examples/user_guide/07-Tabular_Datasets.ipynb .                                                                                [ 91%]
examples/user_guide/08-Gridded_Datasets.ipynb F                                                                                [ 92%]
examples/user_guide/09-Indexing_and_Selecting_Data.ipynb .                                                                     [ 92%]
examples/user_guide/10-Transforming_Elements.ipynb .                                                                           [ 92%]
examples/user_guide/11-Responding_to_Events.ipynb .                                                                            [ 93%]
examples/user_guide/12-Custom_Interactivity.ipynb .                                                                            [ 93%]
examples/user_guide/13-Data_Pipelines.ipynb .                                                                                  [ 94%]
examples/user_guide/14-Large_Data.ipynb .                                                                                      [ 94%]
examples/user_guide/15-Streaming_Data.ipynb .                                                                                  [ 94%]
examples/user_guide/16-Dashboards.ipynb .                                                                                      [ 95%]
examples/user_guide/Colormaps.ipynb .                                                                                          [ 95%]
examples/user_guide/Continuous_Coordinates.ipynb .                                                                             [ 96%]
examples/user_guide/Deploying_Bokeh_Apps.ipynb .                                                                               [ 96%]
examples/user_guide/Exporting_and_Archiving.ipynb .                                                                            [ 97%]
examples/user_guide/Installing_and_Configuring.ipynb .                                                                         [ 97%]
examples/user_guide/Network_Graphs.ipynb .                                                                                     [ 97%]
examples/user_guide/Plots_and_Renderers.ipynb F                                                                                [ 98%]
examples/user_guide/Plotting_with_Bokeh.ipynb .                                                                                [ 98%]
examples/user_guide/Plotting_with_Matplotlib.ipynb .                                                                           [ 99%]
examples/user_guide/Styling_Plots.ipynb .                                                                                      [ 99%]
examples/user_guide/Tips_and_Tricks.ipynb .                                                                                    [100%]

============================================================== FAILURES ==============================================================
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/autompg_histogram.ipynb
line 18 col 0: 'numpy as np' imported but unused
line 19 col 0: 'pandas as pd' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/autompg_violins.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/bachelors_degrees_by_gender.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/bars_economic.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/boxplot_chart.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/dot_example.ipynb
line 16 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/dropdown_economic.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/hextile_movie_ratings.ipynb
line 14 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/iris_density_grid.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/iris_example.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/iris_grouped_grid.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/iris_splom_example.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/point_draw_triangulate.ipynb
line 14 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/route_chord.ipynb
line 18 col 0: 'numpy as np' imported but unused
line 19 col 0: 'pandas as pd' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/scatter_economic.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/step_chart.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/texas_choropleth_example.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/bokeh/topographic_hillshading.ipynb
line 30 col 0: redefinition of unused 'np' from line 20
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/autompg_histogram.ipynb
line 18 col 0: 'numpy as np' imported but unused
line 19 col 0: 'pandas as pd' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/autompg_violins.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/bachelors_degrees_by_gender.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/bars_economic.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/boxplot_chart.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/dropdown_economic.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/hextile_movie_ratings.ipynb
line 14 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/iris_density_grid.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/iris_example.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/iris_grouped_grid.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/iris_splom_example.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/route_chord.ipynb
line 18 col 0: 'numpy as np' imported but unused
line 19 col 0: 'pandas as pd' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/scatter_economic.ipynb
line 18 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/step_chart.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/texas_choropleth_example.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/gallery/demos/matplotlib/topographic_hillshading.ipynb
line 31 col 0: redefinition of unused 'np' from line 20
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/bokeh/Bounds.ipynb
line 22 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/bokeh/Chord.ipynb
line 24 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/bokeh/Graph.ipynb
line 23 col 0: 'pandas as pd' imported but unused
line 25 col 0: 'networkx as nx' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/bokeh/ItemTable.ipynb
line 22 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/bokeh/Sankey.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/bokeh/Spline.ipynb
line 22 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/bokeh/Table.ipynb
line 22 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/bokeh/TriMesh.ipynb
line 23 col 0: 'pandas as pd' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/matplotlib/Bounds.ipynb
line 22 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/matplotlib/Chord.ipynb
line 24 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/matplotlib/Graph.ipynb
line 25 col 0: 'pandas as pd' imported but unused
line 27 col 0: 'networkx as nx' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/matplotlib/ItemTable.ipynb
line 22 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/matplotlib/Sankey.ipynb
line 20 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/matplotlib/Spline.ipynb
line 22 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/matplotlib/Table.ipynb
line 22 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/matplotlib/TriMesh.ipynb
line 23 col 0: 'pandas as pd' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/plotly/ItemTable.ipynb
line 22 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/elements/plotly/Table.ipynb
line 22 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/features/bokeh/table_hooks_example.ipynb
line 14 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/streams/bokeh/BoxEdit.ipynb
line 23 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/streams/bokeh/PointDraw.ipynb
line 23 col 0: 'numpy as np' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/streams/bokeh/PointerX.ipynb
line 25 col 0: 'holoviews.streams' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/streams/bokeh/PolyDraw.ipynb
line 23 col 0: 'numpy as np' imported but unused
line 26 col 0: 'matplotlib.path.Path' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/streams/bokeh/RangeXY.ipynb
line 25 col 0: 'holoviews.streams' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/reference/streams/bokeh/Tap.ipynb
line 26 col 0: 'holoviews.streams' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/topics/simulation/sri_model.ipynb
line 203 col 8: local variable 'spatial_dims' is assigned to but never used
line 250 col 0: 'holoviews.core.options.Palette' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/user_guide/08-Gridded_Datasets.ipynb
line 177 col 0: redefinition of unused 'xr' from line 16
To see python source that was flake checked: pass --nbsmoke-lint-debug
__________________________________________________________________  __________________________________________________________________
/scratch/holoviews/examples/user_guide/Plots_and_Renderers.ipynb
line 29 col 0: 'holoviews.plotting.mpl' imported but unused
To see python source that was flake checked: pass --nbsmoke-lint-debug
=============================================== 62 failed, 177 passed in 18.56 seconds ===============================================

I've 'fixed' these in this PR (except for the last one, which is discussed in one of the previous PRs, and which is a general pyflakes issue).

However, I'm as much testing the flake checking tool as I am looking for hv flakes, so the changes should definitely be inspected. (And in one case I removed an unused variable that was maybe part of the text flow.)

Flakes are supposed to be only things like unused imports and undefined names, which to me means things that would confuse me as a reader - and which I always want someone to remove before I see their code. So I am quite happy for flakes to be errors. But nbsmoke also has an '--only-warn' option, so flakes are just reported by pytest as warnings instead.

@jlstevens
Copy link
Contributor

These changes seem ok to me.

@jbednar
Copy link
Member

jbednar commented May 16, 2018

Looks good to me!

" # Declare dimensions and labels\n",
" spatial_dims = [hv.Dimension('x', range=(-.1, 1.1)),\n",
" hv.Dimension('y', range=(-.1, 1.1))]\n",
" # Declare labels\n",
" state_labels = ['Susceptible', 'Vaccinated', 'Infected', 'Recovered', 'Dead']\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippjfr Definitely unused or a bug?

@jlstevens
Copy link
Contributor

As pretty much all of these are unused imports, I'll go ahead and merge.

@jlstevens jlstevens merged commit 0f5895c into master May 16, 2018
@philippjfr philippjfr deleted the notebook_flakes branch July 4, 2018 11:13
@ceball ceball mentioned this pull request Mar 10, 2019
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants