Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess at how to fix up user guide's Deploying Bokeh Apps #3940

Closed
wants to merge 1 commit into from

Conversation

ceball
Copy link
Member

@ceball ceball commented Sep 1, 2019

Since #4108 was merged, and given existing comments on this PR, I removed #4108's changes from here and made this PR be just about fixing the error in 'Deploying Bokeh Apps':

pytest -v --nbsmoke-lint examples
=========================================================================== test session starts ===========================================================================
platform linux -- Python 3.7.3, pytest-5.2.2, py-1.8.0, pluggy-0.13.0 -- /home/sefkw/mc3/envs/miscdev37/bin/python
cachedir: .pytest_cache
metadata: {'Python': '3.7.3', 'Platform': 'Linux-5.3.0-18-generic-x86_64-with-debian-buster-sid', 'Packages': {'pytest': '5.2.2', 'py': '1.8.0', 'pluggy': '0.13.0'}, 'Plugins': {'html': '2.0.0', 'nbsmoke': '0.3.0', 'metadata': '1.8.0', 'cov': '2.8.1', 'nbval': '0.9.3'}}
rootdir: /home/sefkw/code/holoviz/holoviews
plugins: html-2.0.0, nbsmoke-0.3.0, metadata-1.8.0, cov-2.8.1, nbval-0.9.3
[...]
examples/user_guide/Deploying_Bokeh_Apps.ipynb::/home/sefkw/code/holoviz/holoviews/examples/user_guide/Deploying_Bokeh_Apps.ipynb FAILED                            [ 96%]
[...]
______________________________________________________________________________ test session _______________________________________________________________________________
/home/sefkw/code/holoviz/holoviews/examples/user_guide/Deploying_Bokeh_Apps.ipynb
** line 117 col 27: undefined name 'layout'
** line 151 col 9: undefined name 'layout'
** line 164 col 26: undefined name 'layout'
** line 325 col 0: 'bokeh.io.curdoc' imported but unused
To see python source that was checked by pyflakes: /home/sefkw/code/holoviz/holoviews/examples/user_guide/Deploying_Bokeh_Apps.nbsmoke-debug-postmagicprocess.py
To see python source before magics were handled by nbsmoke: /home/sefkw/code/holoviz/holoviews/examples/user_guide/Deploying_Bokeh_Apps.nbsmoke-debug-premagicprocess.py

I have no idea what was supposed to be there, though :)

@jbednar
Copy link
Member

jbednar commented Sep 3, 2019

@jlstevens , it looks to me like layout is indeed undefined on the first run through the Deploying_Bokeh_Apps.ipynb notebook; do you have any idea what happened? How has it ever worked?

@jbednar
Copy link
Member

jbednar commented Sep 3, 2019

It looks like bokeh.io.curdoc is used in commented-out code, and so should be marked #noqa

@ceball ceball mentioned this pull request Nov 27, 2019
… stored in input cells as it should appear when the notebook is run - but maybe that was necessary for the website? Not sure.
@ceball ceball changed the title Removed unused imports Guess at how to fix up user guide's Deploying Bokeh Apps Nov 27, 2019
@ceball ceball requested a review from jlstevens November 27, 2019 23:19
@philippjfr
Copy link
Member

Sorry this never got merged but since this was added I overhauled that notebook significantly.

@philippjfr philippjfr closed this Sep 2, 2020
@philippjfr philippjfr deleted the unused_imports_ branch April 25, 2022 14:44
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants