Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move to GH Actions #4592

Merged
merged 82 commits into from
Nov 3, 2020
Merged

[WIP] Move to GH Actions #4592

merged 82 commits into from
Nov 3, 2020

Conversation

kcpevey
Copy link
Collaborator

@kcpevey kcpevey commented Sep 3, 2020

Resolves #4565

@kcpevey kcpevey added this to the v1.14.0 milestone Sep 3, 2020
@kcpevey kcpevey self-assigned this Sep 3, 2020
@philippjfr
Copy link
Member

Do you need any permissions to enable this or are you all set?

@kcpevey
Copy link
Collaborator Author

kcpevey commented Sep 3, 2020

I think I'm good for now. I'll let you know if I need access to anything else.

@kcpevey
Copy link
Collaborator Author

kcpevey commented Sep 4, 2020

Ya'll disregard my bumbling around due to not understanding your test setup or what in the world doit was doing. At any rate, I'm getting somewhere now. There are a couple of nit-picky flake failures that I'm going to go ahead and fix. https://github.com/holoviz/holoviews/runs/1071937748?check_suite_focus=true

@kcpevey
Copy link
Collaborator Author

kcpevey commented Sep 4, 2020

Questions/Comments:

  • My understanding of the doit setup:
    • Holoviews uses pyctdev which seems to hijack and implement doit commands
    • tox.ini is also used to define doit commands (quite confusing to search for test_all_recommended but it's defined in tox as _all_recommended)
    • Having half the commands internal and half external took a while to figure out
  • Where are the pyctdev doit commands defined? For example, hv is using doit env_create. I cannot find that code - where does it live?
  • (Related to the above) I can't tell if the tests are supposed to be run via a pip env or a conda env. Which is preferred? Or both? And if conda... how is that env built?
  • The CI builds against the dev channel?

@philippjfr

@philippjfr
Copy link
Member

My understanding of the doit setup:

The steps are:

  1. Use the system python/pip to install pyctdev
  2. Use pyctdev (wrapped by doit) to install miniconda
  3. Activate miniconda
  4. Install pyctdev inside miniconda
  5. Create the test env in miniconda
  6. develop_install into the test environment

Where are the pyctdev doit commands defined? For example, hv is using doit env_create. I cannot find that code - where does it live?

This lives in pyctdev.

(Related to the above) I can't tell if the tests are supposed to be run via a pip env or a conda env. Which is preferred? Or both? And if conda... how is that env built?

The tests should run in the conda env which is created with:

doit env_create
doit develop_install

The CI builds against the dev channel?

Correct

@kcpevey
Copy link
Collaborator Author

kcpevey commented Nov 2, 2020

That's strange, because this passed without the token:
https://github.com/holoviz/holoviews/runs/1333142961?check_suite_focus=true

@philippjfr
Copy link
Member

That's strange, because this passed without the token:

I think it's a limitation of the python 2.7 of the CLI wrapper.

@kcpevey
Copy link
Collaborator Author

kcpevey commented Nov 2, 2020

Tests are passing!

@holoviz-developers
Copy link

Thanks for all your efforts here! I'll merge.

@philippjfr philippjfr merged commit a795949 into master Nov 3, 2020
@kcpevey kcpevey deleted the add_gh_actions branch November 3, 2020 13:49
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to github actions for CI
6 participants