-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement multi-yaxis support #5621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! How does a user configure this behavior? I think we should introduce it as an option at first since it's a change in behavior that some people may previously have been relying on (e.g. by defining dimensions only on the first plot in an overlay, rather than (correctly) defining them on all elements of the overlay).
@jlstevens and I discussed this and I am still strongly of the opinion that we should never enable this by default. Right now you enable this with the My concern with enabling it by default continues to be that it is likely to be much more annoying than useful. Particularly when creating plots directly from DataFrames or xarray you will often overlay things with different column/variable names and a slight mismatch shouldn't result in multiple axes. |
Thanks; I didn't spot |
I think I am happy with |
As I said above and suggested to you, I vote strongly never to enable it by default. |
As I have no strong opinion this is also fine by me! That said, I also think other people may disagree and that this is something to discuss again when the time comes. Specifying an additional flag is more cumbersome and inconvenient though in this case, I could easily be convinced being explicit is the overriding factor. |
We'll see! I'll try setting it on for my workflows, and see what problems it causes in practice. Meanwhile, no need to decide about future possible changes to defaults. |
Is this expected to work with Datashaded plots? |
Yes, absolutely. |
Hi, I am really looking forward to having support for multiple vdim axes. Was wondering if there are plans to include some option to configure an holoviews.Area element with multiple axes such that colors are swapping when y1 and y2 referenced to different axes are crossing. i.e. to make the below example in matplotlib a oneline with bokeh (or other backends) in holoviews.
|
@GeoVizNow, that sounds unrelated to having multiple y axes, and seems like it should be doable already by overlaying multiple hv.Area plots cropped in comparison to a reference curve. Seems like a discourse.holoviz.org topic to propose and see if someone can fill in an example. |
9da6195
to
589716b
Compare
Codecov Report
@@ Coverage Diff @@
## main #5621 +/- ##
==========================================
+ Coverage 88.19% 88.20% +0.01%
==========================================
Files 307 308 +1
Lines 63305 63628 +323
==========================================
+ Hits 55829 56125 +296
- Misses 7476 7503 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bokeh 3 tests are now green! :-) However, something since 2025b5d has broken Bokeh 2 badly (which now hangs. My suspicion is that it could be due to the |
Adding a note as a reminder that we will need a proper fix for the new dask release and to unpin in setup.py! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philippjfr and I have reviewed your code and left some comments and suggestions for you.
Something to note is we haven't reviewed the Javascript code in callback = CustomJS(code=f"""
One last thing is, please doublecheck that all get_extents
has the same signature.
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
Co-authored-by: Jean-Luc Stevens <jlrstevens@gmail.com>
As discussed with @philippjfr, this PR is in a good state and can be merged, and then I will tag a new dev version. Thank you for all your work here, @jlstevens! I know how you have loved every single second of bringing this fantastic functionality to life! |
Of course! :-) |
Thank you for working up this great new feature! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This adds multi-yaxis support to the Bokeh backend.
ToDo
_get_factors