Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie lint #5777

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Pie lint #5777

merged 7 commits into from
Jul 4, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jun 22, 2023

This enables the Flake8-PIE rule: https://beta.ruff.rs/docs/rules/#flake8-pie-pie

The main motivation is to have duplicate-class-field-definition enabled, as this could lead to potential headaches in the future.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Merging #5777 (e7e5af9) into main (3f97338) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5777      +/-   ##
==========================================
- Coverage   88.14%   88.12%   -0.02%     
==========================================
  Files         307      307              
  Lines       62850    62844       -6     
==========================================
- Hits        55401    55384      -17     
- Misses       7449     7460      +11     
Flag Coverage Δ
ui-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
holoviews/element/tiles.py 95.91% <ø> (ø)
holoviews/plotting/mpl/element.py 90.10% <ø> (-0.02%) ⬇️
holoviews/plotting/plot.py 93.51% <ø> (+0.08%) ⬆️
holoviews/plotting/plotly/chart.py 95.09% <ø> (-0.03%) ⬇️
holoviews/plotting/plotly/plot.py 88.50% <ø> (-0.06%) ⬇️
holoviews/util/settings.py 76.89% <ø> (+0.32%) ⬆️
holoviews/core/tree.py 84.26% <100.00%> (ø)
holoviews/plotting/bokeh/element.py 88.08% <100.00%> (-0.01%) ⬇️
holoviews/plotting/mpl/chart.py 64.07% <100.00%> (ø)
holoviews/plotting/plotly/dash.py 81.34% <100.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit ee37d1e into main Jul 4, 2023
@hoxbro hoxbro deleted the pie_lint branch July 4, 2023 09:28
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants