Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure PlotSize stream works with undefined width/height #5868

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

philippjfr
Copy link
Member

Certain operations (such as downsample1D) only require having a set width which means that the height scaling currently errors.

@philippjfr philippjfr marked this pull request as ready for review August 28, 2023 09:49
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #5868 (ca3ba96) into main (04d7fa6) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5868      +/-   ##
==========================================
+ Coverage   88.23%   88.34%   +0.11%     
==========================================
  Files         310      310              
  Lines       63962    63958       -4     
==========================================
+ Hits        56434    56504      +70     
+ Misses       7528     7454      -74     
Flag Coverage Δ
ui-tests 23.40% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/streams.py 87.26% <100.00%> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit dbfacbe into main Aug 28, 2023
14 checks passed
@hoxbro hoxbro deleted the plot_size_stream_fix branch August 28, 2023 11:22
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants