Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping support for Bokeh 2 #5891

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Dropping support for Bokeh 2 #5891

merged 8 commits into from
Oct 11, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 16, 2023

#5751 removed Bokeh 2 from the test suite.

This PR continues it and removes support from the code base.

The sorting of import will be done in another PR, where I will enable automatic linting for it.

@hoxbro hoxbro added this to the 1.18.0 milestone Sep 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Merging #5891 (d2fd3e4) into main (3c414fb) will increase coverage by 0.15%.
Report is 14 commits behind head on main.
The diff coverage is 96.36%.

@@            Coverage Diff             @@
##             main    #5891      +/-   ##
==========================================
+ Coverage   88.41%   88.56%   +0.15%     
==========================================
  Files         312      313       +1     
  Lines       64953    65069     +116     
==========================================
+ Hits        57427    57628     +201     
+ Misses       7526     7441      -85     
Flag Coverage Δ
ui-tests 23.28% <34.54%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
holoviews/plotting/bokeh/callbacks.py 62.20% <100.00%> (-0.12%) ⬇️
holoviews/plotting/bokeh/element.py 88.14% <100.00%> (+0.47%) ⬆️
holoviews/plotting/bokeh/graphs.py 91.25% <ø> (+0.21%) ⬆️
holoviews/plotting/bokeh/links.py 72.35% <100.00%> (+1.56%) ⬆️
holoviews/plotting/bokeh/plot.py 93.13% <100.00%> (+1.28%) ⬆️
holoviews/plotting/bokeh/raster.py 85.09% <100.00%> (+2.04%) ⬆️
holoviews/tests/plotting/bokeh/test_elementplot.py 96.91% <ø> (+0.10%) ⬆️
holoviews/tests/plotting/bokeh/test_graphplot.py 100.00% <100.00%> (+0.75%) ⬆️
holoviews/tests/plotting/bokeh/test_gridplot.py 100.00% <100.00%> (+2.19%) ⬆️
holoviews/tests/plotting/bokeh/test_layoutplot.py 100.00% <100.00%> (+9.44%) ⬆️
... and 4 more

... and 35 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro requested a review from philippjfr October 3, 2023 06:31
@hoxbro hoxbro changed the title Bokeh 2 removal Dropping support for Bokeh 2 Oct 11, 2023
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! All the changes seem straightforward and uncontroversial. LGTM

@hoxbro hoxbro enabled auto-merge (squash) October 11, 2023 10:08
@hoxbro hoxbro merged commit 50c6aa6 into main Oct 11, 2023
11 checks passed
@hoxbro hoxbro deleted the bokeh2_removal branch October 11, 2023 10:41
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants