Fix OrderedDict regression #5925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix is not well received by our test suite. Have to find the underlying issue. |
|
An example with import geoviews as gv
import xarray as xr
from holoviews.operation import contours
gv.extension("bokeh")
ds = xr.tutorial.open_dataset("air_temperature").isel(time=0)
p1 = gv.QuadMesh(ds, kdims=["lon", "lat"])
p2 = contours(p1, filled=True)
p2 |
Codecov Report
@@ Coverage Diff @@
## main #5925 +/- ##
==========================================
- Coverage 88.45% 88.32% -0.14%
==========================================
Files 313 313
Lines 65209 65209
==========================================
- Hits 57683 57595 -88
- Misses 7526 7614 +88
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
It's not an ideal fix, but it no longer errors in our CI or the example above. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5890 which changed
OrderedDicttodict. had a regression which was discovered in hvplot holoviz/hvplot#1164