Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 #5936

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Drop Python 3.8 #5936

merged 3 commits into from
Oct 16, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 12, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #5936 (5a189e6) into main (70477d1) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5936      +/-   ##
==========================================
- Coverage   88.57%   88.53%   -0.05%     
==========================================
  Files         313      313              
  Lines       65086    65100      +14     
==========================================
- Hits        57653    57637      -16     
- Misses       7433     7463      +30     
Flag Coverage Δ
ui-tests 23.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro added this to the 1.18.0 milestone Oct 12, 2023
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and conforms with HEP1.

@hoxbro hoxbro merged commit 04c6eb9 into main Oct 16, 2023
10 checks passed
@hoxbro hoxbro deleted the drop_python38 branch October 16, 2023 10:16
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants